Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test our *2john tools #5433

Open
solardiz opened this issue Feb 2, 2024 · 2 comments
Open

CI: Test our *2john tools #5433

solardiz opened this issue Feb 2, 2024 · 2 comments
Labels
testing A testing task or issue (e.g., with CI)

Comments

@solardiz
Copy link
Member

solardiz commented Feb 2, 2024

We need to start automatic testing of our *2john tools, perhaps on GitHub Actions using inputs from our https://github.com/openwall/john-samples repo. Most of these tools are Python scripts and some have dependencies, so this task might not be completed in one step. It's OK to start with testing our C compiled programs, then proceed to add more.

Also, maybe some of this (not requiring large input files) should become part of our make check (and individual tests automatically skipped when dependencies are not satisfied? so that make check remains usable to test john itself everywhere it currently is).

@solardiz solardiz added the testing A testing task or issue (e.g., with CI) label Feb 2, 2024
@ukasz
Copy link
Contributor

ukasz commented Feb 11, 2024

Do we use self hosted github runners?

@solardiz
Copy link
Member Author

Do we use self hosted github runners?

No, we currently run CI jobs in GitHub and CircleCI infrastructure. I see no need for self-hosted for this task - testing *2john tools. (We could reasonably use self-hosted for testing on GPUs and for performance regression testing, but that's not part of this issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing A testing task or issue (e.g., with CI)
Projects
None yet
Development

No branches or pull requests

2 participants