-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDA not supporting uri containing a colon #5513
Comments
As a temporary (but valid) solution, you can change the separator field. Edit digest and:
A suitable solution could be $HEX support in |
As a side note:
|
I'm not sure we'll have any better solution. We do use colon as field separator by default. Maybe we need to document this problem and solution more prominently, but where? What other solution can we possibly implement? Here are some ideas, out of which I don't like any: One idea is to somehow know there are only 2 fields, and if so only consider the first colon as the field separator. We could magically do this where the are too few colons for this to be a full Another idea is to have a command-line option to claim the number of fields, allowing for values 1 (bare hash) and 2. This would allow to keep the colons intact, but would it be any easier to learn of this problem/solution and use it than the current field separator option? I doubt it. We could maybe base the loader's field count expectation on the hash type, but this mixes two abstraction layers into one, so it could also be unexpected and confusing. Also, it's tricky implementation-wise, in many ways. |
Ah, of course. But even then, where exactly in the documentation, program messages, etc. would we provide such advice, so that it reaches the right people when they bump into this problem?
I wonder why this got printed twice. |
Oh, nevermind, we do allow up to 10 of these by default. |
Thanks, this made it recognizable.
I guess we could also add a heuristic like:
But maybe adding an FAQ answer like the following would be enough:
I use a ~2014 Haswell laptop. Why?
$ cat /proc/cpuinfo | grep -e 'flags*\|model*' | head -3
model : 69
model name : Intel(R) Core(TM) i7-4500U CPU @ 1.80GHz
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm cpuid_fault epb pti ssbd ibrs ibpb stibp tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt dtherm ida arat pln pts vnmi md_clear flush_l1d |
I had doubts about the binary not offering maximum performance (which is bad for the user).
|
Oh, good catch, I opened a downstream issue NixOS/nixpkgs#328226 |
I tried to determine a password for
F1
from an example in https://www.rfc-editor.org/rfc/rfc3665#page-7:I was stuck on
john
not liking the legacy variant:(I later realized that the
Authorization
header itself is actually invalid but that is unrelated to this report.)Looks like it does not like the colon in the
uri
since when I delete it, I getUsing absolute URI is allowed by the specification:
It is also commonly used by Session Initiation Protocol, which does not even allow non-absolute URIs.
I modified the Nix package to point to 367d643:
The text was updated successfully, but these errors were encountered: