Merge pull request #2805 from drgrice1/fix-only-full-group-by-errors

somiaj · web-flow · commit a00a00482b4e · 2025-10-29T23:10:30.000-06:00
Fix issues when the sql_mode includes the only_full_group_by setting.
diff --git a/lib/WeBWorK/Utils/ListingDB.pm b/lib/WeBWorK/Utils/ListingDB.pm
@@ -286,7 +286,7 @@ sub getDBListings ($c, $amcounter = 0) {
 	if ($amcounter) {
 		$selectwhat = "COUNT(DISTINCT $selectwhat)";
 	} else {
-		$selectwhat .= 'as filepath, pgf.morelt_id, pgf.pgfile_id, pgf.static, pgf.MO';
+		$selectwhat .= 'as filepath, MAX(pgf.morelt_id), MAX(pgf.pgfile_id), MAX(pgf.static), MAX(pgf.MO)';
 		$group_by = 'GROUP BY filepath';
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ sub getDBListings ($c, $amcounter = 0) {`
`286`	`286`	`if ($amcounter) {`
`287`	`287`	`$selectwhat = "COUNT(DISTINCT $selectwhat)";`
`288`	`288`	`} else {`
`289`		`- $selectwhat .= 'as filepath, pgf.morelt_id, pgf.pgfile_id, pgf.static, pgf.MO';`
	`289`	`+ $selectwhat .= 'as filepath, MAX(pgf.morelt_id), MAX(pgf.pgfile_id), MAX(pgf.static), MAX(pgf.MO)';`
`290`	`290`	`$group_by = 'GROUP BY filepath';`
`291`	`291`	`}`
`292`	`292`