test: address review comments and fix format

Signed-off-by: Dennis-Mircea Ciupitu <dennis.mircea.ciupitu@gmail.com>

Author: Dennis-Mircea

operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstate/ExternalStateTestBase.java

@@ -15,18 +15,20 @@
  */
 package io.javaoperatorsdk.operator.dependent.externalstate;
 
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
 
 import io.fabric8.kubernetes.api.model.ConfigMap;
 import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
 import io.javaoperatorsdk.operator.junit.LocallyRunOperatorExtension;
 import io.javaoperatorsdk.operator.support.ExternalIDGenServiceMock;
+import io.javaoperatorsdk.operator.support.ExternalServiceResetExtension;
 
 import static io.javaoperatorsdk.operator.dependent.externalstate.ExternalStateReconciler.ID_KEY;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.awaitility.Awaitility.await;
 
+@ExtendWith(ExternalServiceResetExtension.class)
 public abstract class ExternalStateTestBase {
 
   private static final String TEST_RESOURCE_NAME = "test1";
@@ -36,11 +38,6 @@ public abstract class ExternalStateTestBase {
 
   private final ExternalIDGenServiceMock externalService = ExternalIDGenServiceMock.getInstance();
 
-  @BeforeEach
-  void resetExternalService() {
-    externalService.reset();
-  }
-
   @Test
   public void reconcilesResourceWithPersistentState() {
     var resource = extension().create(testResource());

operator-framework/src/test/java/io/javaoperatorsdk/operator/dependent/externalstate/externalstatebulkdependent/ExternalStateBulkIT.java

@@ -17,14 +17,15 @@
 
 import java.time.Duration;
 
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
 import io.javaoperatorsdk.annotation.Sample;
 import io.javaoperatorsdk.operator.junit.LocallyRunOperatorExtension;
 import io.javaoperatorsdk.operator.support.ExternalIDGenServiceMock;
+import io.javaoperatorsdk.operator.support.ExternalServiceResetExtension;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.awaitility.Awaitility.await;
@@ -38,6 +39,7 @@
         allowing operators to track and reconcile a variable number of external resources with \
         persistent state that survives operator restarts.
         """)
+@ExtendWith(ExternalServiceResetExtension.class)
 class ExternalStateBulkIT {
 
   private static final String TEST_RESOURCE_NAME = "test1";
@@ -50,11 +52,6 @@ class ExternalStateBulkIT {
 
   private final ExternalIDGenServiceMock externalService = ExternalIDGenServiceMock.getInstance();
 
-  @BeforeEach
-  void resetExternalService() {
-    externalService.reset();
-  }
-
   @RegisterExtension
   LocallyRunOperatorExtension operator =
       LocallyRunOperatorExtension.builder()

operator-framework/src/test/java/io/javaoperatorsdk/operator/support/ExternalIDGenServiceMock.java

@@ -51,8 +51,8 @@ public List<ExternalResource> listResources() {
   }
 
   /**
-   * Clears the internal state. Intended to be called between tests so that state from one test
-   * does not leak into the next via this JVM-lifetime singleton.
+   * Clears the internal state. Intended to be called between tests so that state from one test does
+   * not leak into the next via this JVM-lifetime singleton.
    */
   public void reset() {
     resourceMap.clear();

operator-framework/src/test/java/io/javaoperatorsdk/operator/support/ExternalServiceResetExtension.java

@@ -0,0 +1,33 @@
+/*
+ * Copyright Java Operator SDK Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.javaoperatorsdk.operator.support;
+
+import org.jspecify.annotations.NonNull;
+import org.junit.jupiter.api.extension.BeforeEachCallback;
+import org.junit.jupiter.api.extension.ExtensionContext;
+
+/**
+ * Resets the {@link ExternalIDGenServiceMock} singleton before each test method so that state from
+ * one test does not leak into the next. Apply via
+ * {@code @ExtendWith(ExternalServiceResetExtension.class)}.
+ */
+public class ExternalServiceResetExtension implements BeforeEachCallback {
+
+  @Override
+  public void beforeEach(@NonNull ExtensionContext context) {
+    ExternalIDGenServiceMock.getInstance().reset();
+  }
+}