fix: remove isClusterScoped method from Controller

A controller is not cluster-scoped, its associated custom resource type
is. As such, this functionality should (and is) controlled by the
custom resource type associated with the controller, not the controller
itself. If a custom resource implementation doesn't implement Namespaced
then it is cluster-scoped.

Author: metacosm

README.md

@@ -63,7 +63,11 @@ Note that these docs are currently in progress.
   types, so you can have an empty default implementation that does what you'd expect. If you don't
   need a status, using `Void` for the associated type should work.
 - Custom Resources that are namespace-scoped need to implement the `Namespaced` interface so that
-  the client can generate the proper URLs.
+  the client can generate the proper URLs. This means, in particular, that `CustomResource`
+  implementations that do **not** implement `Namespaced` are considered cluster-scoped. As a
+  consequence, the `isClusterScoped` method/field has been removed from the appropriate
+  classes (`Controller` annotation, in particular) as this is now inferred from the `CustomResource`
+  type associated with your `Controller`.
 
 Many of these changes might not be immediately apparent but will result in `404` errors when
 connecting to the cluster. Please check that the Custom Resource implementations are properly

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/Controller.java

@@ -26,7 +26,15 @@
    */
   boolean generationAwareEventProcessing() default true;
 
-  boolean isClusterScoped() default false;
-
+  /**
+   * Specified which namespaces this Controller monitors for custom resources events. If no
+   * namespace is specified then the controller will monitor the namespace it is deployed in (or the
+   * namespace to which the Kubernetes client is connected to). To specify that the controller needs
+   * to monitor all namespaces, add {@link
+   * io.javaoperatorsdk.operator.api.config.ControllerConfiguration#WATCH_ALL_NAMESPACES_MARKER} to
+   * this field.
+   *
+   * @return the list of namespaces this controller monitors
+   */
   String[] namespaces() default {};
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfiguration.java

@@ -20,10 +20,6 @@ public interface ControllerConfiguration<R extends CustomResource> {
 
   String getAssociatedControllerClassName();
 
-  default boolean isClusterScoped() {
-    return false;
-  }
-
   default Set<String> getNamespaces() {
     return Collections.emptySet();
   }

operator-framework-quarkus-extension/deployment/src/main/java/io/javaoperatorsdk/quarkus/extension/deployment/QuarkusExtensionProcessor.java

@@ -160,8 +160,6 @@ private ControllerConfiguration createControllerConfiguration(
                 "generationAwareEventProcessing",
                 AnnotationValue::asBoolean,
                 () -> true),
-            valueOrDefault(
-                controllerAnnotation, "isClusterScoped", AnnotationValue::asBoolean, () -> false),
             QuarkusControllerConfiguration.asSet(
                 valueOrDefault(
                     controllerAnnotation,

operator-framework-quarkus-extension/runtime/src/main/java/io/javaoperatorsdk/quarkus/extension/QuarkusControllerConfiguration.java

@@ -14,7 +14,6 @@ public class QuarkusControllerConfiguration<R extends CustomResource>
   private final String crdName;
   private final String finalizer;
   private final boolean generationAware;
-  private final boolean clusterScoped;
   private final Set<String> namespaces;
   private final String crClass;
   private final boolean watchAllNamespaces;
@@ -27,7 +26,6 @@ public QuarkusControllerConfiguration(
       String crdName,
       String finalizer,
       boolean generationAware,
-      boolean clusterScoped,
       Set<String> namespaces,
       String crClass,
       RetryConfiguration retryConfiguration) {
@@ -36,7 +34,6 @@ public QuarkusControllerConfiguration(
     this.crdName = crdName;
     this.finalizer = finalizer;
     this.generationAware = generationAware;
-    this.clusterScoped = clusterScoped;
     this.namespaces = namespaces;
     this.crClass = crClass;
     this.watchAllNamespaces = this.namespaces.contains(WATCH_ALL_NAMESPACES_MARKER);
@@ -100,11 +97,6 @@ public String getAssociatedControllerClassName() {
     return associatedControllerClassName;
   }
 
-  @Override
-  public boolean isClusterScoped() {
-    return clusterScoped;
-  }
-
   @Override
   public Set<String> getNamespaces() {
     return namespaces;

operator-framework-quarkus-extension/tests/src/main/java/io/javaoperatorsdk/quarkus/it/TestOperatorApp.java

@@ -65,10 +65,6 @@ public String getAssociatedControllerClassName() {
       return conf.getAssociatedControllerClassName();
     }
 
-    public boolean isClusterScoped() {
-      return conf.isClusterScoped();
-    }
-
     public Set<String> getNamespaces() {
       return conf.getNamespaces();
     }

operator-framework-spring-boot-starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/OperatorAutoConfiguration.java

@@ -100,11 +100,6 @@ public Class<R> getCustomResourceClass() {
       return super.getCustomResourceClass();
     }
 
-    @Override
-    public boolean isClusterScoped() {
-      return properties.map(ControllerProperties::isClusterScoped).orElse(super.isClusterScoped());
-    }
-
     @Override
     public Set<String> getNamespaces() {
       return properties.map(ControllerProperties::getNamespaces).orElse(super.getNamespaces());

operator-framework/src/main/java/io/javaoperatorsdk/operator/config/runtime/AnnotationConfiguration.java

@@ -47,11 +47,6 @@ public Class<R> getCustomResourceClass() {
     return RuntimeControllerMetadata.getCustomResourceClass(controller);
   }
 
-  @Override
-  public boolean isClusterScoped() {
-    return annotation.isClusterScoped();
-  }
-
   @Override
   public Set<String> getNamespaces() {
     return Set.of(annotation.namespaces());