Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 7608163

Browse files
committedJan 26, 2021
fix: rename getProject to getSdkVersion for greater clarity
Note that the rename trickles down to several spots because Quarkus' @RecordableConstructor is sensitive to parameter names: the parameter names used in the constructor must match an existing getter.
1 parent d4d48cd commit 7608163

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed
 

‎operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public void start() {
3737
final var version = configurationService.getVersion();
3838
log.info(
3939
"Operator {} (commit: {}) built on {} starting...",
40-
version.getProject(),
40+
version.getSdkVersion(),
4141
version.getCommit(),
4242
version.getBuiltTime());
4343
}

‎operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/Version.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
/** A class encapsulating the version information associated with this SDK instance. */
66
public class Version {
77

8-
private final String project;
8+
private final String sdk;
99
private final String commit;
1010
private final Date builtTime;
1111

12-
public Version(String project, String commit, Date builtTime) {
13-
this.project = project;
12+
public Version(String sdkVersion, String commit, Date builtTime) {
13+
this.sdk = sdkVersion;
1414
this.commit = commit;
1515
this.builtTime = builtTime;
1616
}
@@ -20,8 +20,8 @@ public Version(String project, String commit, Date builtTime) {
2020
*
2121
* @return the SDK project version
2222
*/
23-
public String getProject() {
24-
return project;
23+
public String getSdkVersion() {
24+
return sdk;
2525
}
2626

2727
/**

‎operator-framework-quarkus-extension/deployment/src/main/java/io/javaoperatorsdk/quarkus/extension/deployment/QuarkusExtensionProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void createConfigurationServiceAndOperator(
8585

8686
final var supplier =
8787
recorder.configurationServiceSupplier(
88-
new Version(version.getProject(), version.getCommit(), version.getBuiltTime()),
88+
new Version(version.getSdkVersion(), version.getCommit(), version.getBuiltTime()),
8989
controllerConfigs);
9090
syntheticBeanBuildItemBuildProducer.produce(
9191
SyntheticBeanBuildItem.configure(QuarkusConfigurationService.class)

‎operator-framework-quarkus-extension/runtime/src/main/java/io/javaoperatorsdk/quarkus/extension/Version.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
public class Version extends io.javaoperatorsdk.operator.api.config.Version {
88

99
@RecordableConstructor
10-
public Version(String project, String commit, Date builtTime) {
11-
super(project, commit, builtTime);
10+
public Version(String sdkVersion, String commit, Date builtTime) {
11+
super(sdkVersion, commit, builtTime);
1212
}
1313
}

0 commit comments

Comments
 (0)
Please sign in to comment.