-
Notifications
You must be signed in to change notification settings - Fork 66
✨ prototyping dynamic graphql handler for catalogd #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Joe Lanford <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7deca0f
to
f0f601d
Compare
Signed-off-by: Joe Lanford <[email protected]>
f0f601d
to
c4cdc70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 73.48% 70.05% -3.43%
==========================================
Files 78 94 +16
Lines 7240 8052 +812
==========================================
+ Hits 5320 5641 +321
- Misses 1568 2033 +465
- Partials 352 378 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Veeeeeerrrrrrrrrry rough around the edges PR that gets a graphql handler added to the catalogd server (behind a feature gate). Not really happy at all yet with the library refactoring that adds the
Indexer
andIndex
types. But for now it at least gets the job done for this prototype.The idea here is that when we store an FBC, we build up a graphql schema dynamically based on the content of the FBC. The result being that catalogd is still a "dumb pipe" for FBC data. The GraphQL API is directly derived from the FBC API (or at least the parts of the FBC API that are in use somewhere in the served FBC).
To play with it, I've enabled the GraphQL explorer handler, so you can:
And then open https://localhost:8443/catalogs/operatorhubio/api/v1/graphql
And here's are some interesting queries to run:
Bundle search metadata
What OLMv1 operator-controller actually needs for resolution:
Reviewer Checklist