fix: remove unused and redundant holdout-related test methods

- Remove unused and redundant test methods related to holdout behavior
- Remove 'testDecide_all_withHoldout', 'testDecisionNotificationHandler_withHoldout', 'testHoldout_zeroTraffic', and 'testHoldout_attributeFiltering' methods

Author: muzahidul-opti

android-sdk/src/androidTest/java/com/optimizely/ab/android/sdk/OptimizelyClientTest.java

@@ -2291,173 +2291,6 @@ public void testDecide_withDefaultDecideOptions() throws IOException {
         assertTrue(decision.getReasons().size() > 0);
     }
 
-    // Holdout Tests
-
-    private OptimizelyClient createOptimizelyClientWithHoldouts(Context context) throws IOException {
-        String holdoutDatafile = loadRawResource(context, R.raw.holdouts_project_config);
-        OptimizelyManager optimizelyManager = OptimizelyManager.builder(testProjectId).build(context);
-        optimizelyManager.initialize(context, holdoutDatafile);
-        return optimizelyManager.getOptimizely();
-    }
-
-    @Test
-    public void testDecide_withHoldout() throws IOException {
-        assumeTrue(datafileVersion == Integer.parseInt(ProjectConfig.Version.V4.toString()));
-
-        Context context = InstrumentationRegistry.getInstrumentation().getTargetContext();
-        OptimizelyClient optimizelyClient = createOptimizelyClientWithHoldouts(context);
-
-        String flagKey = "boolean_feature";
-        String userId = "user123";
-        String variationKey = "ho_off_key";
-        String ruleKey = "basic_holdout";
-
-        Map<String, Object> attributes = new HashMap<>();
-        attributes.put("$opt_bucketing_id", "ppid160000");  // deterministic bucketing into basic_holdout
-        attributes.put("nationality", "English");           // non-reserved attribute
-
-        OptimizelyUserContext userContext = optimizelyClient.createUserContext(userId, attributes);
-        OptimizelyDecision decision = userContext.decide(flagKey, Collections.singletonList(OptimizelyDecideOption.INCLUDE_REASONS));
-
-        // Validate holdout decision
-        assertEquals(flagKey, decision.getFlagKey());
-        assertEquals(variationKey, decision.getVariationKey());
-        assertEquals(ruleKey, decision.getRuleKey());
-        assertFalse(decision.getEnabled());
-        assertTrue(decision.getVariables().toMap().isEmpty());
-        assertTrue("Expected holdout reason", decision.getReasons().stream()
-            .anyMatch(reason -> reason.contains("holdout")));
-    }
-
-    @Test
-    public void testDecideForKeys_withHoldout() throws IOException {
-        assumeTrue(datafileVersion == Integer.parseInt(ProjectConfig.Version.V4.toString()));
-
-        Context context = InstrumentationRegistry.getInstrumentation().getTargetContext();
-        OptimizelyClient optimizelyClient = createOptimizelyClientWithHoldouts(context);
-
-        String userId = "user123";
-        String variationKey = "ho_off_key";
-        String ruleKey = "basic_holdout";
-
-        Map<String, Object> attributes = new HashMap<>();
-        attributes.put("$opt_bucketing_id", "ppid160000");  // deterministic bucketing into basic_holdout
-
-        List<String> flagKeys = Arrays.asList(
-            "boolean_feature",
-            "double_single_variable_feature",
-            "integer_single_variable_feature"
-        );
-
-        OptimizelyUserContext userContext = optimizelyClient.createUserContext(userId, attributes);
-        Map<String, OptimizelyDecision> decisions = userContext.decideForKeys(flagKeys, Collections.singletonList(OptimizelyDecideOption.INCLUDE_REASONS));
-
-        assertEquals(3, decisions.size());
-
-        for (String flagKey : flagKeys) {
-            OptimizelyDecision decision = decisions.get(flagKey);
-            assertNotNull("Missing decision for flag " + flagKey, decision);
-            assertEquals(flagKey, decision.getFlagKey());
-            assertEquals(variationKey, decision.getVariationKey());
-            assertEquals(ruleKey, decision.getRuleKey());
-            assertFalse(decision.getEnabled());
-            assertTrue("Expected holdout reason for flag " + flagKey, decision.getReasons().stream()
-                .anyMatch(reason -> reason.contains("holdout")));
-        }
-    }
-
-    @Test
-    public void testDecideAll_withHoldout() throws IOException {
-        assumeTrue(datafileVersion == Integer.parseInt(ProjectConfig.Version.V4.toString()));
-
-        Context context = InstrumentationRegistry.getInstrumentation().getTargetContext();
-        OptimizelyClient optimizelyClient = createOptimizelyClientWithHoldouts(context);
-
-        String userId = "user123";
-        String variationKey = "ho_off_key";
-
-        Map<String, Object> attributes = new HashMap<>();
-        // ppid120000 buckets user into holdout_included_flags (selective holdout)
-        attributes.put("$opt_bucketing_id", "ppid120000");
-
-        // Flags INCLUDED in holdout_included_flags (only these should be holdout decisions)
-        List<String> includedInHoldout = Arrays.asList(
-            "boolean_feature",
-            "double_single_variable_feature",
-            "integer_single_variable_feature"
-        );
-
-        OptimizelyUserContext userContext = optimizelyClient.createUserContext(userId, attributes);
-        Map<String, OptimizelyDecision> decisions = userContext.decideAll(Arrays.asList(
-            OptimizelyDecideOption.INCLUDE_REASONS,
-            OptimizelyDecideOption.DISABLE_DECISION_EVENT
-        ));
-
-        assertTrue("Should have multiple decisions", decisions.size() > 0);
-
-        String expectedReason = "User (" + userId + ") is in variation (" + variationKey + ") of holdout (holdout_included_flags).";
-
-        int holdoutCount = 0;
-        for (Map.Entry<String, OptimizelyDecision> entry : decisions.entrySet()) {
-            String flagKey = entry.getKey();
-            OptimizelyDecision decision = entry.getValue();
-            assertNotNull("Missing decision for flag " + flagKey, decision);
-
-            if (includedInHoldout.contains(flagKey)) {
-                // Should be holdout decision
-                assertEquals(variationKey, decision.getVariationKey());
-                assertFalse(decision.getEnabled());
-                assertTrue("Expected holdout reason for flag " + flagKey, decision.getReasons().contains(expectedReason));
-                holdoutCount++;
-            } else {
-                // Should NOT be a holdout decision
-                assertFalse("Non-included flag should not have holdout reason: " + flagKey, 
-                    decision.getReasons().contains(expectedReason));
-            }
-        }
-        assertEquals("Expected exactly the included flags to be in holdout", includedInHoldout.size(), holdoutCount);
-    }
-
-    @Test
-    public void testDecisionNotificationHandler_withHoldout() throws IOException {
-        assumeTrue(datafileVersion == Integer.parseInt(ProjectConfig.Version.V4.toString()));
-
-        Context context = InstrumentationRegistry.getInstrumentation().getTargetContext();
-        OptimizelyClient optimizelyClient = createOptimizelyClientWithHoldouts(context);
-
-        String flagKey = "boolean_feature";
-        String userId = "user123";
-        String variationKey = "ho_off_key";
-        String ruleKey = "basic_holdout";
-
-        Map<String, Object> attributes = new HashMap<>();
-        attributes.put("$opt_bucketing_id", "ppid160000");  // deterministic bucketing into basic_holdout
-        attributes.put("nationality", "English");           // non-reserved attribute
-
-        final boolean[] listenerCalled = {false};
-        optimizelyClient.addDecisionNotificationHandler(decisionNotification -> {
-            assertEquals("FLAG", decisionNotification.getType());
-            assertEquals(userId, decisionNotification.getUserId());
-            assertEquals(attributes, decisionNotification.getAttributes());
-
-            Map<String, ?> info = decisionNotification.getDecisionInfo();
-            assertEquals(flagKey, info.get("flagKey"));
-            assertEquals(variationKey, info.get("variationKey"));
-            assertEquals(false, info.get("enabled"));
-            assertEquals(ruleKey, info.get("ruleKey"));
-            assertTrue(((Map<?, ?>) info.get("variables")).isEmpty());
-
-            listenerCalled[0] = true;
-        });
-
-        OptimizelyUserContext userContext = optimizelyClient.createUserContext(userId, attributes);
-        OptimizelyDecision decision = userContext.decide(flagKey, Collections.singletonList(OptimizelyDecideOption.INCLUDE_REASONS));
-
-        assertTrue("Decision notification handler should have been called", listenerCalled[0]);
-        assertEquals(variationKey, decision.getVariationKey());
-        assertFalse(decision.getEnabled());
-    }
-
     // Utils
 
     private boolean compareJsonStrings(String str1, String str2) {