reason format fix

Author: junaed-optimizely

OptimizelySDK.Tests/CmabTests/DecisionServiceCmabTest.cs

@@ -105,7 +105,7 @@ public void TestGetVariationWithCmabExperimentReturnsVariation()
 
             var reasons = result.DecisionReasons.ToReport(true);
             var expectedMessage =
-                $"CMAB decision fetched for user [{TEST_USER_ID}] in experiment [{TEST_EXPERIMENT_KEY}].";
+                $"CMAB decision fetched for user {TEST_USER_ID} in experiment {TEST_EXPERIMENT_KEY}.";
             Assert.Contains(expectedMessage, reasons);
 
             _cmabServiceMock.Verify(c => c.GetDecision(
@@ -187,12 +187,11 @@ public void TestGetVariationWithCmabExperimentServiceError()
             Assert.IsTrue(result.ResultObject.CmabError);
 
             var reasonsList = result.DecisionReasons.ToReport(true);
+
             Assert.IsTrue(reasonsList.Exists(reason =>
                     reason.Contains(
-                        $"Failed to fetch CMAB decision for experiment [{TEST_EXPERIMENT_KEY}].")),
+                        $"Failed to fetch CMAB decision for experiment {TEST_EXPERIMENT_KEY}.")),
                 $"Decision reasons should include CMAB fetch failure. Actual reasons: {string.Join(", ", reasonsList)}");
-            Assert.IsTrue(reasonsList.Exists(reason => reason.Contains("Error: CMAB service error")),
-                $"Decision reasons should include CMAB service error text. Actual reasons: {string.Join(", ", reasonsList)}");
 
             _cmabServiceMock.Verify(c => c.GetDecision(
                 It.IsAny<ProjectConfig>(),
@@ -313,7 +312,7 @@ public void TestGetVariationWithCmabExperimentCacheHit()
 
             var reasons = result2.DecisionReasons.ToReport(true);
             var expectedMessage =
-                $"CMAB decision fetched for user [{TEST_USER_ID}] in experiment [{TEST_EXPERIMENT_KEY}].";
+                $"CMAB decision fetched for user {TEST_USER_ID} in experiment {TEST_EXPERIMENT_KEY}.";
             Assert.Contains(expectedMessage, reasons);
         }
 

OptimizelySDK/Bucketing/DecisionService.cs

@@ -338,10 +338,11 @@ OptimizelyDecideOption[] options
                 return Result<VariationDecisionResult>.NewResult(
                     new VariationDecisionResult(variation, cmabDecision.CmabUuid), reasons);
             }
-            catch (Exception ex)
+            catch (Exception)
             {
                 var message = string.Format(CmabConstants.CMAB_FETCH_FAILED, experiment.Key);
-                Logger.Log(LogLevel.ERROR, reasons.AddInfo($"{message} Error: {ex.Message}"));
+                reasons.AddError(message);
+                Logger.Log(LogLevel.ERROR, message);
                 return Result<VariationDecisionResult>.NewResult(
                     new VariationDecisionResult(null, null, true), reasons);
             }

OptimizelySDK/Cmab/CmabConstants.cs

@@ -32,13 +32,10 @@ internal static class CmabConstants
             "User [{0}] not in CMAB experiment [{1}] due to traffic allocation.";
 
         public const string CMAB_FETCH_FAILED =
-            "Failed to fetch CMAB decision for experiment [{0}].";
+            "Failed to fetch CMAB decision for experiment {0}.";
 
         public const string CMAB_DECISION_FETCHED =
-            "CMAB decision fetched for user [{0}] in experiment [{1}].";
-
-        public const string CMAB_EXPERIMENT_NOT_PROPERLY_CONFIGURED =
-            "CMAB experiment [{0}] is not properly configured.";
+            "CMAB decision fetched for user {0} in experiment {1}.";
 
         public static readonly TimeSpan MAX_TIMEOUT = TimeSpan.FromSeconds(10);
         public static readonly TimeSpan DEFAULT_CACHE_TTL = TimeSpan.FromMinutes(10);