Skip to content

Commit 7dc7c14

Browse files
committed
Remove experiment decision changes
1 parent d813b31 commit 7dc7c14

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

core-api/src/main/java/com/optimizely/ab/notification/DecisionNotification.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,9 @@ public static ExperimentDecisionNotificationBuilder newExperimentDecisionNotific
9797
public static class ExperimentDecisionNotificationBuilder {
9898
public final static String EXPERIMENT_KEY = "experimentKey";
9999
public final static String VARIATION_KEY = "variationKey";
100-
public final static String EXPERIMENT_ID = "experimentId";
101-
public final static String VARIATION_ID = "variationId";
102100

103101
private String type;
104102
private String experimentKey;
105-
private String experimentId;
106-
private String variationId;
107103
private Variation variation;
108104
private String userId;
109105
private Map<String, ?> attributes;
@@ -134,16 +130,6 @@ public ExperimentDecisionNotificationBuilder withVariation(Variation variation)
134130
return this;
135131
}
136132

137-
public ExperimentDecisionNotificationBuilder withExperimentId(String experimentId) {
138-
this.experimentId = experimentId;
139-
return this;
140-
}
141-
142-
public ExperimentDecisionNotificationBuilder withVariationId(String variationId) {
143-
this.variationId = variationId;
144-
return this;
145-
}
146-
147133
public DecisionNotification build() {
148134
if (type == null) {
149135
throw new OptimizelyRuntimeException("type not set");
@@ -155,9 +141,7 @@ public DecisionNotification build() {
155141

156142
decisionInfo = new HashMap<>();
157143
decisionInfo.put(EXPERIMENT_KEY, experimentKey);
158-
decisionInfo.put(EXPERIMENT_ID, experimentId);
159144
decisionInfo.put(VARIATION_KEY, variation != null ? variation.getKey() : null);
160-
decisionInfo.put(VARIATION_ID, variationId);
161145

162146
return new DecisionNotification(
163147
type,

core-api/src/test/java/com/optimizely/ab/notification/DecisionNotificationTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,13 @@ public class DecisionNotificationTest {
3737

3838
private static final Boolean FEATURE_ENABLED = Boolean.FALSE;
3939
private static final String EXPERIMENT_KEY = "experimentKey";
40-
private static final String EXPERIMENT_ID = "1234567";
4140
private static final String FEATURE_KEY = "featureKey";
4241
private static final String FEATURE_VARIABLE_KEY = "featureVariableKey";
4342
private static final String FEATURE_TEST = "featureTest";
4443
private static final String FEATURE_TEST_VARIATION = "featureTestVariation";
4544
private static final String USER_ID = "userID";
4645
private static final Map<String, String> USER_ATTRIBUTES = Collections.singletonMap("user", "attr");
4746
private static final Variation VARIATION = mock(Variation.class);
48-
private static final String VARIATION_ID = "1234567";
4947

5048
private FeatureTestSourceInfo featureTestSourceInfo;
5149
private RolloutSourceInfo rolloutSourceInfo;
@@ -60,8 +58,6 @@ public void setUp() {
6058
.withAttributes(USER_ATTRIBUTES)
6159
.withExperimentKey(EXPERIMENT_KEY)
6260
.withVariation(VARIATION)
63-
.withExperimentId(EXPERIMENT_ID)
64-
.withVariationId(VARIATION_ID)
6561
.withType(NotificationCenter.DecisionNotificationType.AB_TEST.toString())
6662
.build();
6763
featureTestSourceInfo = new FeatureTestSourceInfo(FEATURE_TEST, FEATURE_TEST_VARIATION);
@@ -111,8 +107,6 @@ public void testGetDecisionInfo() {
111107
HashMap<String, String> expectedExperimentDecisionInfo = new HashMap<>();
112108
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.EXPERIMENT_KEY, EXPERIMENT_KEY);
113109
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.VARIATION_KEY, VARIATION.getKey());
114-
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.EXPERIMENT_ID, EXPERIMENT_ID);
115-
expectedExperimentDecisionInfo.put(DecisionNotification.ExperimentDecisionNotificationBuilder.VARIATION_ID, VARIATION_ID);
116110
assertEquals(expectedExperimentDecisionInfo, experimentDecisionNotification.getDecisionInfo());
117111

118112
// Assert for Feature's DecisionInfo

0 commit comments

Comments
 (0)