Skip to content

Commit 0e1e678

Browse files
committed
update
1 parent 936816b commit 0e1e678

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lib/event_processor/event_builder/log_event.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import {
2222
import { ImpressionEvent, ConversionEvent } from './user_event';
2323

2424
describe('makeEventBatch', () => {
25-
it('should build a batch with simgle impression event when experiment and variation are defined', () => {
25+
it('should build a batch with single impression event when experiment and variation are defined', () => {
2626
const impressionEvent: ImpressionEvent = {
2727
type: 'impression',
2828
timestamp: 69,
@@ -220,7 +220,7 @@ describe('makeEventBatch', () => {
220220
})
221221
});
222222

223-
it('should build a batch with single conversion event whenwhen tags object is defined', () => {
223+
it('should build a batch with single conversion event when tags object is defined', () => {
224224
const conversionEvent: ConversionEvent = {
225225
type: 'conversion',
226226
timestamp: 69,

lib/event_processor/event_builder/user_event.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ export type ImpressionEvent = BaseUserEvent<'impression'> & {
8181
};
8282

8383
export type ConversionEvent = BaseUserEvent<'conversion'> & {
84-
type: 'conversion';
85-
8684
event: {
8785
id: string | null;
8886
key: string;

0 commit comments

Comments
 (0)