Skip to content

Peer review #6

@anttiromppanen

Description

@anttiromppanen

Couldn't get code working on linux in reasonable time, so review is solely based on the codebase. Not a problem or critic though, since applications are often developed for a specific platform in mind. Screenshots of the program looks good, simple and clear UI, and judging from pictures the application does what it's supposed to do.

Code itself is written well, it is easy to read and easy to skim through. Folder structure is also well thought, and files itself contain methods or functions that seem to follow the basic principles of good code, which makes the code easy to read. This is more of a personal preference, and it is probably a good convention to use a lot of comments, but the methods and variables have already often good descriptive names, so sometimes the comments feel a bit of a overhead. On the other hand they may help on intellisense though, not sure haven't used C# much.

Project looks very good overall, there's probably always ways to optimize the algorithms especially, but they are already more than likely better than I could come up with.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions