reduce verbosity of tests

Author: alan-maguire

TESTING.md

@@ -18,13 +18,17 @@ requiring netns cookie support are skipped automatically.
 Install packages used to facilitate testing:
 
 ```
-$ sudo dnf install iperf3 qperf kernel-uek-modules-extra clang llvm bpftool libbpf-devel libcap-devel 
+$ sudo dnf install iperf3 qperf proxyt kernel-uek-modules-extra clang llvm bpftool libbpf-devel libcap-devel 
 $ sudo dnf module install container-tools:ol8
 ```
 
 iperf3, qperf are needed for perf testing; kernel-uek-modules-extra is
-needed for sch-netem; the latter 5 packages are needed to build the sample
-tuner.
+needed for sch-netem; proxyt is used by podman to connect to the container
+registry; may not be needed depending on the network connectivity/podman
+config used.  If podman is not installed or registry reachable, tests
+will be skipped.
+
+The latter 5 packages are needed to build the sample tuner.
 
 podman is optional and is used to verify container support in bpftune.
 

test/neigh_table_legacy_test.sh

@@ -24,7 +24,7 @@ for TUNER in neigh_table ; do
 
    test_setup "true"
 
-   test_run_cmd_local "$BPFTUNE -dsL &" true
+   test_run_cmd_local "$BPFTUNE -sL &" true
 
    sleep $SETUPTIME
 
@@ -49,10 +49,6 @@ for TUNER in neigh_table ; do
 	$PREFIX_CMD ip neigh replace $ip6addr lladdr $macaddr dev $INTF
       fi
    done
-   echo "Following changes were made:"
-   set +e  
-   grep bpftune $LOGFILE
-   set -e
    grep "table nearly full" $LOGFILE
    test_pass
   done

test/neigh_table_test.sh

@@ -24,7 +24,7 @@ for TUNER in neigh_table ; do
 
    test_setup "true"
 
-   test_run_cmd_local "$BPFTUNE -ds &" true
+   test_run_cmd_local "$BPFTUNE -s &" true
 
    sleep $SETUPTIME
 
@@ -49,10 +49,6 @@ for TUNER in neigh_table ; do
 	$PREFIX_CMD ip neigh replace $ip6addr lladdr $macaddr dev $INTF
       fi
    done
-   echo "Following changes were made:"
-   set +e  
-   grep bpftune $LOGFILE
-   set -e
    grep "table nearly full" $LOGFILE
    test_pass
   done

test/rmem_legacy_test.sh

@@ -43,7 +43,7 @@ for FAMILY in ipv4 ipv6 ; do
 	echo "Running ${MODE}..."
 	test_run_cmd_local "ip netns exec $NETNS $IPERF3 -s -p $PORT -1 &"
 	if [[ $MODE != "baseline" ]]; then
-		test_run_cmd_local "$BPFTUNE -dL &"
+		test_run_cmd_local "$BPFTUNE -L &"
 		sleep $SETUPTIME
 	else
 		LOGSZ=$(wc -l $LOGFILE | awk '{print $1}')

test/rmem_test.sh

@@ -43,7 +43,7 @@ for FAMILY in ipv4 ipv6 ; do
 	echo "Running ${MODE}..."
 	test_run_cmd_local "ip netns exec $NETNS $IPERF3 -s -p $PORT -1 &"
 	if [[ $MODE != "baseline" ]]; then
-		test_run_cmd_local "$BPFTUNE -d &"
+		test_run_cmd_local "$BPFTUNE &"
 		sleep $SETUPTIME
 	else
 		LOGSZ=$(wc -l $LOGFILE | awk '{print $1}')

test/route_table_test.sh

@@ -36,7 +36,7 @@ for TUNER in route_table ; do
    $PREFIX_CMD sysctl -w net.ipv6.route.gc_thresh=16
    $PREFIX_CMD sysctl -w net.ipv6.route.max_size=32
 
-   test_run_cmd_local "$BPFTUNE -ds &" true
+   test_run_cmd_local "$BPFTUNE -s &" true
 
    sleep $SETUPTIME
 
@@ -54,10 +54,6 @@ for TUNER in route_table ; do
    sleep $SLEEPTIME
    sleep $SLEEPTIME
    sleep $SLEEPTIME
-   echo "Following changes were made:"
-   set +e  
-   grep bpftune $LOGFILE
-   set -e
    max_size_post=($($PREFIX_CMD sysctl -n net.ipv6.route.max_size))
    $PREFIX_CMD sysctl -w net.ipv6.route.max_size="$max_size_orig"
    $PREFIX_CMD sysctl -w net.ipv6.route.gc_thresh="$thresh_orig"

test/sysctl_legacy_test.sh

@@ -17,7 +17,7 @@ for TUNER in neigh_table ; do
 
    test_setup "true"
 
-   test_run_cmd_local "$BPFTUNE -dsL &" true
+   test_run_cmd_local "$BPFTUNE -sL &" true
 
    sleep $SETUPTIME
    for SYSCTL in net.ipv4.neigh.default.gc_thresh1 kernel.core_pattern ; do

test/sysctl_netns_test.sh

@@ -21,7 +21,7 @@ for TUNER in neigh_table ; do
 
    sysctl -qw net.ipv4.tcp_rmem="${rmem_orig[0]} ${rmem_orig[1]} ${rmem_orig[1]}"
 
-   test_run_cmd_local "$BPFTUNE -ds &" true
+   test_run_cmd_local "$BPFTUNE -s &" true
 
    sleep $SETUPTIME
 

test/sysctl_test.sh

@@ -17,7 +17,7 @@ for TUNER in neigh_table ; do
 
    test_setup "true"
 
-   test_run_cmd_local "$BPFTUNE -ds &" true
+   test_run_cmd_local "$BPFTUNE -s &" true
 
    sleep $SETUPTIME
    for SYSCTL in net.ipv4.neigh.default.gc_thresh1 kernel.core_pattern ; do