Skip to content

Commit 89331a5

Browse files
committed
Update release notes and test cases
1 parent 85792da commit 89331a5

File tree

6 files changed

+178
-97
lines changed

6 files changed

+178
-97
lines changed

doc/src/release_notes.rst

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,6 @@ Common Changes
1919
Thin Mode Changes
2020
++++++++++++++++++
2121

22-
#) Internal code refactoring to improve connection performance when using
23-
input easy connection Strings.
24-
25-
#) Fixed bug that throws an 'ORA-01000' error when a query is executed multiple
26-
times even though query returned errors like 'NJS-119', 'NJS-016'.
27-
28-
#) Internal performance optimizations for network buffer and packet handling
29-
30-
#) Ensure that the database port is passed as a number to the network connection.
31-
See `Issue #1600 <https://github.com/oracle/node-oracledb/issues/1600>`__
32-
and `PR #1601 <https://github.com/oracle/node-oracledb/pull/1601>`__
33-
(Daniel Rodrigues).
34-
3522
#) Improved statement bind variable placeholder parser performance, handle
3623
statements which use the `Alternative Quoting Mechanism
3724
<https://www.oracle.com/pls/topic/lookup?ctx=dblatest&id=GUID-1824CBAA-6E16-4921-B2A6-112FB02248DA>`__
@@ -48,6 +35,19 @@ Thin Mode Changes
4835
#) Fixed bug that prevented getting the value of a RAW attribute on a DbObject
4936
which is null.
5037

38+
#) Fixed bug which caused a cursor leak while repeatedly executing a SQL
39+
statement that fails with an NJS- prefixed error.
40+
41+
#) Ensure that the database port is passed as a number to the network connection.
42+
See `Issue #1600 <https://github.com/oracle/node-oracledb/issues/1600>`__
43+
and `PR #1601 <https://github.com/oracle/node-oracledb/pull/1601>`__
44+
(Daniel Rodrigues).
45+
46+
#) Internal code refactoring to improve connection performance when using
47+
Easy Connect strings.
48+
49+
#) Internal performance optimizations for network buffer and packet handling.
50+
5151
Thick Mode Changes
5252
++++++++++++++++++
5353

test/aq5.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ describe('281.aq5.js', function() {
9292
`;
9393

9494
await conn.execute(plsql);
95-
await conn.commit ();
95+
await conn.commit();
9696
}
9797
}); //before
9898

@@ -119,13 +119,13 @@ describe('281.aq5.js', function() {
119119
const queue1 = await conn.getQueue(objQueueName);
120120
const messageString = 'This is my message';
121121
await queue1.enqOne(messageString);
122-
await conn.commit ();
122+
await conn.commit();
123123

124124

125125
// Dequeue
126126
const queue2 = await conn.getQueue(objQueueName);
127-
const msg = await queue2.deqOne ();
128-
await conn.commit ();
127+
const msg = await queue2.deqOne();
128+
await conn.commit();
129129
assert(msg);
130130

131131
await conn.unsubscribe(objQueueName);

test/aq6.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -171,24 +171,24 @@ describe('282. aq6.js', function() {
171171

172172
it('282.2.1 enqOne and deqOne Json val as array type', async function() {
173173
let msg;
174-
const queue = await conn.getQueue (objQueueName,
174+
const queue = await conn.getQueue(objQueueName,
175175
{ payloadType: oracledb.DB_TYPE_JSON }
176176
);
177177

178178
msg = await queue.enqOne ({
179179
payload: { "employees":[ "Employee1", "Employee2", "Employee3" ] },
180180
});
181181

182-
await conn.commit ();
182+
await conn.commit();
183183

184184
/*Dequeue*/
185185
const options = { payloadType: oracledb.DB_TYPE_JSON };
186186
const queue2 = await conn.getQueue(objQueueName, options);
187-
msg = await queue2.deqOne ();
187+
msg = await queue2.deqOne();
188188
assert(msg);
189189
assert(msg.msgId.length > 0);
190190
assert(msg.msgId instanceof Buffer);
191-
await conn.commit ();
191+
await conn.commit();
192192
}); //282.2.1
193193

194194
it('282.2.2 JSON type in enqMany/deqMany', async () => {
@@ -201,8 +201,8 @@ describe('282. aq6.js', function() {
201201
{payload: { empName: "Employee #3", empId: 103 }}
202202
];
203203

204-
await queue3.enqMany (empList);
205-
await conn.commit ();
204+
await queue3.enqMany(empList);
205+
await conn.commit();
206206

207207
const options = { payloadType: oracledb.DB_TYPE_JSON };
208208
const queue4 = await conn.getQueue(objQueueName, options);
@@ -302,7 +302,7 @@ describe('282. aq6.js', function() {
302302
ADDRESS: "300 Oracle Parkway Redwood City, CA US 94065"
303303
},
304304
{
305-
NAME: "Lawrance",
305+
NAME: "Lawrence",
306306
ADDRESS: "400 Oracle Parkway Redwood City, CA US 94065"
307307
}
308308
];

0 commit comments

Comments
 (0)