Merge pull request #3224 from vladak/stats_authnz_metric_cleanup

remove project/stack specific authorization metrics

Author: tarzanek

opengrok-indexer/src/main/java/org/opengrok/indexer/authorization/AuthorizationFramework.java

@@ -536,16 +536,13 @@ private boolean checkAll(HttpServletRequest request, String cache, Nameable enti
             lock.readLock().unlock();
         }
 
+        // Update the timers.
         authTimer.record(duration);
         if (overallDecision) {
             authPositiveTimer.record(duration);
         } else {
             authNegativeTimer.record(duration);
         }
-        Metrics.getRegistry().timer(String.format("authorization_of_%s", entity.getName())).record(duration);
-        Metrics.getRegistry()
-                .timer(String.format("authorization_%s_of_%s", overallDecision ? "positive" : "negative", entity.getName()))
-                .record(duration);
 
         m.put(entity.getName(), overallDecision);
         request.setAttribute(cache, m);

opengrok-indexer/src/main/java/org/opengrok/indexer/authorization/AuthorizationStack.java

@@ -23,8 +23,6 @@
  */
 package org.opengrok.indexer.authorization;
 
-import java.time.Duration;
-import java.time.Instant;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
@@ -33,7 +31,6 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-import org.opengrok.indexer.Metrics;
 import org.opengrok.indexer.configuration.Nameable;
 import org.opengrok.indexer.logger.LoggerFactory;
 
@@ -224,8 +221,6 @@ protected boolean processStack(Nameable entity,
             PluginDecisionPredicate pluginPredicate,
             PluginSkippingPredicate skippingPredicate) {
 
-        Instant start = Instant.now();
-
         boolean overallDecision = true;
         for (AuthorizationEntity authEntity : getStack()) {
 
@@ -283,19 +278,6 @@ protected boolean processStack(Nameable entity,
                 }
             }
         }
-        Duration duration = Duration.between(start, Instant.now());
-
-        Metrics.getRegistry()
-                .timer(String.format("authorization_in_stack_%s_%s", getName(),
-                        overallDecision ? "positive" : "negative"))
-                .record(duration);
-        Metrics.getRegistry()
-                .timer(String.format("authorization_in_stack_%s_%s_of_%s", getName(),
-                        overallDecision ? "positive" : "negative", entity.getName()))
-                .record(duration);
-        Metrics.getRegistry()
-                .timer(String.format("authorization_in_stack_%s_of_%s", getName(), entity.getName()))
-                .record(duration);
 
         return overallDecision;
     }