GH-512 save username and password when it was stored previously

Author: thurka

visualvm/jmx/src/org/graalvm/visualvm/jmx/CredentialsProvider.java

@@ -81,7 +81,7 @@ public String getId() {
 
     abstract boolean hasPassword(Storage storage);
 
-    abstract boolean isPersistent(Storage storage);
+    public abstract boolean isPersistent(Storage storage);
 
 
     /**
@@ -144,7 +144,7 @@ private char[] getPassword(Storage storage) {
         boolean hasPassword(Storage storage) { return pword != null &&
                                                pword.length > 0; }
 
-        boolean isPersistent(Storage storage) { return persistent; }
+        public boolean isPersistent(Storage storage) { return persistent; }
 
     }
 
@@ -196,7 +196,7 @@ boolean hasPassword(Storage storage) {
             return pword != null && pword.length>0;
         }
 
-        boolean isPersistent(Storage storage) {
+        public boolean isPersistent(Storage storage) {
             return getUsername(storage) != null || hasPassword(storage);
         }
 

visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/ProxyClient.java

@@ -51,6 +51,7 @@
 import org.graalvm.visualvm.application.type.ApplicationType;
 import org.graalvm.visualvm.core.datasource.Storage;
 import org.graalvm.visualvm.core.datasource.descriptor.DataSourceDescriptor;
+import org.graalvm.visualvm.jmx.CredentialsProvider;
 import org.graalvm.visualvm.jmx.EnvironmentProvider;
 import org.graalvm.visualvm.tools.jmx.JmxModel;
 import org.openide.DialogDisplayer;
@@ -125,8 +126,13 @@ private ProxyClient(Application app, JMXServiceURL url, EnvironmentProvider envP
     }
 
     void setCredentials(String user, char[] pword) {
-        this.user = user;
-        this.pword = pword;
+        if (envProvider instanceof CredentialsProvider && ((CredentialsProvider)envProvider).isPersistent(app.getStorage())) {
+            EnvironmentProvider epr = new CredentialsProvider.Custom(user, pword, true);
+            epr.saveEnvironment(app.getStorage());
+        } else {
+            this.user = user;
+            this.pword = pword;
+        }
     }
 
     boolean hasSSLStubCheck() {