Homebrew
Neovim: build and distribute parsers #3611
Replies: 5 comments 23 replies
-
|
I did notice that we don't bundle the C parser, which seems to be the only bundled parser in the latest nightly build at the time of writing. No one seems to have missed them up until now. I have the C, Lua, and Vim parsers installed via nvim-treesitter so I guess I wouldn't have noticed needing to bundle them either. I'm not opposed to bundling them or shipping them as separate formulae and adding them as |
Beta Was this translation helpful? Give feedback.
-
|
I see. That will be a problem then. In that case, you'll probably have to separate them into HEAD and stable blocks and live with the churn (or disable the |
Beta Was this translation helpful? Give feedback.
-
This seems like the simplest thing to do for now... if users complain, then we can entertain other ideas. Feel free to point said complaints to this thread so they can add to the discussion. |
Beta Was this translation helpful? Give feedback.
-
|
OK, that gives us a few weeks to figure out how to deal with 0.8 (expected September 30), where "Lua treesitter highlighting out of the box" is a marquee feature... |
Beta Was this translation helpful? Give feedback.
-
|
Including parsers for the stable release is easy -- they can be |
Beta Was this translation helpful? Give feedback.
-
|
That sounds like a reasonable compromise. If you want to track the development branch, you should really build from source yourself anyway (or use the provided nightlies) to help with issues. |
Beta Was this translation helpful? Give feedback.
-
Yes, they were not used by Neovim core. That has changed now. (The goal is to support treesitter highlighting without requiring an external plugin.) (I'm not complaining about the old status quo; just interested in getting the homebrew build up to current spec.) |
Beta Was this translation helpful? Give feedback.
-
|
I've opened Homebrew/homebrew-core#109966 to throw a warning about the not-included parsers for |
Beta Was this translation helpful? Give feedback.
-
|
How do other distros handle the distribution of parsers? If they're all doing similar things, it may make sense to just follow them, so thinking about downstream isn't too complicated for Neovim. |
Beta Was this translation helpful? Give feedback.
-
|
@carlocab neovim now automatically enables treesitter-based syntax highlighting for its help files, by default. (as of neovim/neovim#26347) this results in an ugly error, on a fresh install without any user configs (using this makes can this be revisted? You mentioned that there's a policy against letting scripts download artifacts untracked by homebrew. could this be relaxed, if only for the diff --git a/Formula/n/neovim.rb b/Formula/n/neovim.rb
index 413783e42e0..c1c34015a65 100644
--- a/Formula/n/neovim.rb
+++ b/Formula/n/neovim.rb
@@ -124,6 +124,12 @@ class Neovim < Formula
end
end
end
+ else
+ system "cmake", "-S", "cmake.deps", "-B", ".deps",
+ "-DUSE_BUNDLED=false",
+ "-DUSE_BUNDLED_TS_PARSERS=true",
+ *std_cmake_args
+ system "cmake", "--build", ".deps"
end
# Point system locations inside `HOMEBREW_PREFIX`.
@@ -148,15 +154,6 @@ class Neovim < Formula
system "cmake", "--install", "build"
end
- def caveats
- return if latest_head_version.blank?
-
- <<~EOS
- HEAD installs of Neovim do not include any tree-sitter parsers.
- You can use the `nvim-treesitter` plugin to install them.
- EOS
- end
-
test do
refute_match "dirty", shell_output("#{bin}/nvim --version")
(testpath/"test.txt").write("Hello World from Vim!!") |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
that's exactly what I'm doing. I'm just using the formula to build from source so homebrew can keep track of the installation. I already committed the change I suggested to my local install. The change would only affect users building w/ unrelated, but surprisingly a lot of distros' official packages are missing the treesitter parsers. Arch, Alpine, OpenSUSE, Gentoo all package neovim 0.9.5 without them. The packages I've seen that include them so far are homebrew and debian. |
Beta Was this translation helpful? Give feedback.
-
Then you are not in fact doing what I'm telling you to do. Clone the repo,
Not a coincidence. |
Beta Was this translation helpful? Give feedback.
-
Not sure what the implication is supposed to be here, sorry.
I think you misunderstand, I'm not asking for support. I've already solved my issue. I just think that if the formula contains a HEAD it should be built properly, but it's not a demand or a request. It's a suggestion. And I'm only offering it because that's specifically what @carlocab asked for:
If that is unwanted the maintainers can feel free to ignore it. it's no sweat off my back |
Beta Was this translation helpful? Give feedback.
-
|
As a point of rare agreement between vim and emacs users, it would also be nice for homebrew's emacs formula and cask if the tree-sitter parsers were packaged for homebrew. Emacs does have a command to install the libraries but it requires several manual steps or at the very least some copy-pasting from the internet and trusting it works. Would the homebrew team be open to the idea of including the parsers with the resource "tree-sitter-c" do
url "https://github.com/tree-sitter/tree-sitter-c.git", tag: "v0.20.8"
revision: "b125bec9b331722e4eaab6e02e1fe5b14eefd967"
endfollowed by a section in resources.each do |r|
libname = "lib#{r.name}.dylib"
r.stage do
cd "src" do
system ENV.cc, "-fPIC", "-c", "-I.", "parser.c"
system ENV.cc, "-fPIC", "-c", "-I.", "scanner.c"
system ENV.cc, "-fPIC", "-shared", "*.o", "-o", libname
lib.install libname
end
end
end |
Beta Was this translation helpful? Give feedback.
-
|
However much I like to agree on something, that's the opposite of what I'm asking for... (Bundled queries are only guaranteed to be compatible with specific parser revisions, so we can't trust random libs on the filesystem.) |
Beta Was this translation helpful? Give feedback.
-
|
Alas! Sorry about the misread. Potentially emacs could follow your lead and bundle the libraries in the formula and cask though that does seem like a lot of duplication. At this point I think it comes down to what the maintainers will accept? |
Beta Was this translation helpful? Give feedback.
-
|
You could make their life easier by just using Neovim's queries (to guarantee you can use the same parser version) ;) |
Beta Was this translation helpful? Give feedback.
-
It seems like Homebrew previously did not build and distribute the C parser as part of the installation. However, since neovim/neovim#15391, tree-sitter-parsers (C, Lua, Viml) are now a mandatory part of the Neovim distribution, which means that
--HEAD(and 0.8 when that releases in a few weeks) has to be considered broken.The default build installs these in
/usr/local/lib/nvim/parsers, although they will be found anywhere inruntimepath(including/usr/local/share/nvim/runtime/parsers). But since ordering matters, it would be unfortunate if homebrew diverged from the canonical location.Note that we will possibly add more parsers during the 0.9 release cycle, so it would be better not to hard-code specific parsers. Also, while we endeavor to stick to tagged versions for releases, we may use pre-release commits for nightly and ship corresponding queries in runtime (which may be incompatible with releases).
@carlocab
Beta Was this translation helpful? Give feedback.
All reactions