Attempting to upgrade sslyze formula but open questions #5932
Unanswered
ffloimair
asked this question in
Writing Formulae/Casks
Replies: 1 comment 2 replies
-
Not really, we need to have a way to ensure it works.
Does it not build from source on intel?
Yes it does: https://docs.brew.sh/Bottles#creation |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Output of
brew config
Output of
brew doctor
Description of issue
Hi!
I'm currently trying to update the sslyze formula. It was previously deprecated due to a dependency on [email protected] which is no longer the case with version 6.0.0 or 6.1.0.
Keep in mind that this is my first attempt on a homebrew formula so please be easy on me.
So far everything is looking good to me except that the test step fails. This is due to a problem with the cryptography package used by sslyze. There exists a github issue for that: nabla-c0d3/sslyze#656
Would it be acceptable if I filed this formula with the test steps commented out for now?
Some other questions that I couldn't yet wrap my head around:
sslyze 6.1.0 states that it no longer supports Intel-based Macs. It might work though but I can't test it. I have added a
depends_on arch: :arm64
clause for now but I am not sure if that is correctwhat about the bottles section in the formula. Will this be auto-updated by a CI build once I push the commit and the PR gets accepted? I couldn't find anything in the docs about it.
I am thankful for any hints and tips.
As soon as I feel confident, that I have done everything as intended I will create a PR for it.
Best regards
Florian
Beta Was this translation helpful? Give feedback.
All reactions