Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

Use v8go to compile templates too #45

Open
gwennlbh opened this issue Jun 5, 2022 · 1 comment
Open

Use v8go to compile templates too #45

gwennlbh opened this issue Jun 5, 2022 · 1 comment
Assignees
@gwennlbh
Labels
perf Performance-related

Comments

@gwennlbh
Copy link
Member

gwennlbh commented Jun 5, 2022

Use the same isolate that is used for running all instances of that template. Shelling out might be what causes compilation of templates to be so slow (0.5s per template). Or maybe pug is just slow to compile and in that case not much can be done about this.
@gwennlbh gwennlbh added the perf Performance-related label Jun 5, 2022
@gwennlbh gwennlbh self-assigned this Jun 5, 2022
@gwennlbh
Copy link
Member Author

gwennlbh commented Jun 5, 2022

pprof results show that more than 50% of duration is spent outside of Go (so shelled out):
pprof_result

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gwennlbh gwennlbh

Labels
perf Performance-related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gwennlbh