feat: show social sign in on credentials select #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a story book component for identifier first credentials select. Closes #342
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 42.43% 42.13% -0.30%
==========================================
Files 136 138 +2
Lines 2008 2110 +102
Branches 288 313 +25
==========================================
+ Hits 852 889 +37
- Misses 1149 1209 +60
- Partials 7 12 +5
|
jonas-jonas
requested changes
Jan 29, 2025
| return !exclude.includes(node.group) | ||
| }) | ||
|
|
||
| console.log(otherNodes) |
There was a problem hiding this comment.
Suggested change
| console.log(otherNodes) |
| ? listOnly(Object.keys(providers).filter((key) => providers[key])) | ||
| : LoginFlowFromJSON(oidcNodes) | ||
|
|
||
| console.log({ flow, oidcNodes }) |
There was a problem hiding this comment.
Suggested change
| console.log({ flow, oidcNodes }) |
|
I don't think this is the right approach. #358 |
auto-merge was automatically disabled
February 17, 2025 13:48
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a story book component for identifier first credentials select.
Closes #342