Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating credentials manifest resets other non-exposed fields in API #148

Open
4 of 5 tasks
wizrds opened this issue Jul 6, 2024 · 0 comments
Open
4 of 5 tasks
Labels
bug Something is not working.

Comments

@wizrds
Copy link

wizrds commented Jul 6, 2024

Preflight checklist

Ory Network Project

No response

Describe the bug

We self host hydra as well as the maester in our k8s cluster. We have created some credentials by adding a new manifest and applying it. Afterwards, the client_credentials_grant_access_token_lifespan was manually updated (since it isn't exposed in the credentials manifest schema) to a non-default value of 5 hours.

Later on, the manifest for those credentials were updated by adding a new redirect URI item to the list, then applied again. Afterwards, the response from the hydra API for those credentials showed that the client_credentials_grant_access_token_lifespan was no longer the value we set but reset back to the default None.

This shouldn't happen as not only does that field not even exist in the CRD but it wasn't explicitly changed at all.

Reproducing the bug

  1. Setup hydra and hydra-maester in k8s environment
  2. Create new OAuth2Client manifest with configuration and apply
  3. Manually update client_credentials_grant_access_token_lifespan to a different value via hydra API
  4. Add new redirect URI and apply again in previous manifest
  5. client_credentials_grant_access_token_lifespan is reset

Relevant log output

No response

Relevant configuration

No response

Version

Hydra v2.2.0 and Hydra Maester v0.0.33-amd64

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes

Additional Context

No response

@wizrds wizrds added the bug Something is not working. label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant