-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid path to GAP executable in sysinfo #1105
Comments
One place where this came up is in this comment: #1079 (comment) Also in PR #1067 (see comments in the diff of that PR) we see that some GAP packages (mostly from the homalg project?) would like to launch GAP processes and fail if they can't find one. However, those don't use |
This approach (using the currently active environment) seems very prone to race conditions to me. If multiple julia sessions with GAP.jl loaded share the same |
We currently do this in
regenerate_gaproot()
:However, there is no
bin/gap.sh
ingaproot_mutable
.This is irrelevant most of the time, but when building packages it may be important, as some package use that variable in their build system to find a GAP executable, e.g. so they can build their manuals.
So we could use
create_gap_sh()
or a variant of that to provide that. (A variation because at the very least, we'd want to silence the@info
messages there. But also this command creates a fresh Julia environment which is comparatively slow. Perhaps instead we could just generate a script that uses the currently active environment, or something like that?)The text was updated successfully, but these errors were encountered: