Merge pull request #2 from oshx/fix/error

경고 수정 후 constructor 문제로 오류 생기는 문제 수정
PR 생성 시 오류 나는 문제 확인을 위한 변경

.github/workflows/pullrequest.yml

@@ -1,32 +1,19 @@
-name: GitHub Actions for Pages Deployment
+name: GitHub Actions for Pull Request
 run-name: ${{ github.actor }} is running out GitHub Actions 🚀
 on:
   pull_request:
     branches:
       - master
 jobs:
-  deploy:
+  pullrequest:
     runs-on: ubuntu-latest
-    permissions:
-      pages: write
-      id-token: write
-    environment:
-      name: github-pages
-      url: ${{ steps.deployment.outputs.page_url }}
     steps:
       - name: Check out
         uses: actions/checkout@v4
       - run: echo "🎉 Event [${{ github.event_name }}] | 🔎 Repository [${{ github.repository }}] | 🐧 OS [${{ runner.os }}] | ⭐ Branch[${{ github.ref }}]"
-
       - name: Node.js
         uses: actions/setup-node@v4
         with:
           node-version: 18
       - run: npm ci
       - run: npm run build
-      - name: Setup Pages
-        uses: actions/configure-pages@v5
-      - name: Upload artifact
-        uses: actions/upload-pages-artifact@v3
-        with:
-          path: './public/'

src/App.svelte

@@ -1,7 +1,7 @@
 <script>
-  import * as routes from "./router/routes.config";
-  import * as Router from "svelte-spa-router";
-  import * as Credit from "./components/Credit.svelte";
+  import routes from "~/src/router/routes.config";
+  import Router from "svelte-spa-router";
+  import Credit from "~/src/components/Credit.svelte";
 </script>
 
 <Router {routes} />

src/app.js

@@ -1,4 +1,4 @@
-import * as App from "~/src/App.svelte";
+import App from "~/src/App.svelte";
 
 const app = new App({
   target: window.document.body,

src/pages/Experiment.page.svelte

@@ -3,10 +3,10 @@
   import { convertAnswerToParam } from "~/src/core/ecr";
   import { href, push } from "~/src/router/helper";
   import { PATH_RESULT } from "~/src/router/routes.config";
-  import * as ExperimentSheet from "~/src/components/ExperimentSheet.svelte";
-  import * as ProgressManager from "~/src/components/ProgressManager.svelte";
-  import * as Message from "~/src/components/Message.svelte";
-  import * as InformationSheet from "~/src/components/InformationSheet.svelte";
+  import ExperimentSheet from "~/src/components/ExperimentSheet.svelte";
+  import ProgressManager from "~/src/components/ProgressManager.svelte";
+  import Message from "~/src/components/Message.svelte";
+  import InformationSheet from "~/src/components/InformationSheet.svelte";
 
   let message = null;
   let answerList = Array(QuestionList.length).fill(0);

src/pages/Result.page.svelte

@@ -2,10 +2,10 @@
   import { beforeUpdate } from "svelte";
   import { convertParamToScore, convertScoreToResult } from "~/src/core/ecr";
   import { SERVICE_NAME } from "~/src/core/constants";
-  import * as ExperimentSheet from "~/src/components/ExperimentSheet.svelte";
+  import ExperimentSheet from "~/src/components/ExperimentSheet.svelte";
   import { PATH_EXPERIMENT } from "~/src/router/routes.config";
   import { href, link } from "~/src/router/helper";
-  import * as InformationSheet from "~/src/components/InformationSheet.svelte";
+  import InformationSheet from "~/src/components/InformationSheet.svelte";
 
   export let params;
 

src/router/routes.config.js

@@ -1,6 +1,6 @@
-import * as PageExperiment from "~/src/pages/Experiment.page.svelte";
-import * as PageResult from "~/src/pages/Result.page.svelte";
-import * as PageNotFound from "~/src/pages/NotFound.page.svelte";
+import PageExperiment from "~/src/pages/Experiment.page.svelte";
+import PageResult from "~/src/pages/Result.page.svelte";
+import PageNotFound from "~/src/pages/NotFound.page.svelte";
 
 export const PATH_EXPERIMENT = "/";
 export const PATH_RESULT = "/results/:result";