Fix: Issue #227 #230
Fix: Issue #227 #230
Conversation
There was a problem hiding this comment.
@teamomiamigo Good effort! I like the way you mentioned the comments—good job. However, all checks have failed, and one test case is failing.
Take a look at this one:
'MorePage - Main View › should call logout when the Logout menu item is pressed.'
Also, write test cases for all the functionalities present in MorePage.
Note:
- Pull the latest code from the updateBottomTabBar branch and start working on it. This will help you resolve the 'All checks have failed' issue.
- Run the tests before committing the code.
the extra test cases are added and the morescreen.test.tsx runs and passes when doing yarn test -u. |
There was a problem hiding this comment.
@teamomiamigo Fantastic job! Also, please add test cases for the carousel, as well as for the dark mode and light mode components.
What was changed
Updated the MorePage Tests:
they have been updated to align with the redesigned UI and the new functionalities that have been added. In particular, the tests now properly await async operations and verify the presence of all the main menu items and any modal behaviors that are present in the MoreScreen. The test for the logout button was failing because it wasn’t being properly tracked, and that has been fixed as well, as well as figuring out which are async and await to guarantee that the UI updates completely before anything is done.
Why it was changed:
the MoreScreen was changed, and because of this various test cases were failing and not in correlation with the new MoreScreen. These changes in the test file were necessary to ensure that all aspects of the MorePage component-from rendering to functionality-are all reliably tested.
How it was changed
test functions were updated in relation to the UI structure and the structure of the code of the new MoreScreen.
all the previous commits before mine are made from the updateTabBar branch that Karthik had been previously working on and where he updated the morepage.