Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and serve terminate when encountering the first file that cannot be parsed #51

Open
3 tasks done
manastungare opened this issue Aug 29, 2023 · 3 comments
Open
3 tasks done
Labels

Comments

@manastungare
Copy link

manastungare commented Aug 29, 2023

Checklist

  • I have searched the issue list for my issue.
  • I have verified the behavior with jekyll.
  • I tried hard to create a reproducible test case.

System information

Liquid version: 9718b42

Steps to reproduce the behavior

Minimal test case:

<div markdown="1">

<br>
<br>

</div>

Actual behavior

  1. When a single file cannot be parsed, gojekyll terminates. With the current behavior, you have to fix one file at a time, and cannot see any patterns that might have been otherwise obvious.
  2. gojekyll terminates with filename.md: markdown: EOF. This is not enough information to debug what’s wrong in that file.
  3. The file contains markdown="1". Although the README says markdown="span" and markdown="block" are not supported, it does not explicitly say that markdown="1" is not supported.

Expected behavior

  1. Keep going even if one file has an error, and report all errors to the user.
  2. A better error message than filename.md: markdown: EOF would really help in debugging, especially if a feature is known not to be supported.
  3. If the lack of support for markdown="1" is a known issue, then this should be added to the README in addition to markdown="span" and "block".

Possible Solutions

Listed above.

Thanks for a great tool, hoping I can use it as a drop-in replacement soon!

@danog
Copy link
Collaborator

danog commented Aug 29, 2023

Hi, could you provide a reproducing repo (i.e. as a github repo, or a zip/tar)? Using the snippet you provided works fine on my machine when placed in a .md file.

@manastungare
Copy link
Author

Apologies, it seems the breakage happens with the <br> tags, not simply with markdown="1". I updated the inline example. Kramdown appears to be able to consume it just fine.

$ ./build.sh
Configuration file: none
            Source: …/gojekyll-issue-51
       Destination: …/gojekyll-issue-51/_site
      Generating...
early-access.md: markdown: EOF

gojekyll-issue-51.zip

@danog danog added the bug label Aug 29, 2023
@chimbori
Copy link
Contributor

Auto-closed tags <br/> are a good workaround. (posting from my own alias)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants