Skip to content

fix(S3) if the part is too small and is not ended wait for more data before sending #16453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 18, 2025

Conversation

cirospaciari
Copy link
Member

@cirospaciari cirospaciari commented Jan 17, 2025

What does this PR do?

Fix: #16452
Fix: #16505

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Test

@robobun
Copy link
Collaborator

robobun commented Jan 17, 2025

Updated 12:29 PM PT - Jan 17th, 2025

@cirospaciari, your commit f03d121 has passed in #9935! 🎉


🧪   try this PR locally:

bunx bun-pr 16453

@cirospaciari cirospaciari force-pushed the ciro/fix-multipart-upload-size branch from 5fd4f3c to f5b1c39 Compare January 17, 2025 00:55
@cirospaciari cirospaciari marked this pull request as draft January 17, 2025 01:09
@cirospaciari cirospaciari marked this pull request as ready for review January 17, 2025 01:15
@cirospaciari cirospaciari marked this pull request as draft January 17, 2025 01:30
@cirospaciari cirospaciari marked this pull request as ready for review January 17, 2025 02:10
@cirospaciari cirospaciari force-pushed the ciro/fix-multipart-upload-size branch from 4fc3cbe to f03d121 Compare January 17, 2025 19:46
@Jarred-Sumner Jarred-Sumner added this pull request to the merge queue Jan 18, 2025
@Jarred-Sumner Jarred-Sumner removed this pull request from the merge queue due to a manual request Jan 18, 2025
@Jarred-Sumner Jarred-Sumner merged commit e0e4a27 into main Jan 18, 2025
69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-multipart-upload-size branch January 18, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun.write('s3://remote.tgz', Bun.file('local.tgz') syntax doesn't quite work Errors for multi-part uploads using the new Bun S3 capability
3 participants