Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection without the Connection suffix #341

Open
sylfabre opened this issue Jun 6, 2018 · 2 comments
Open

Connection without the Connection suffix #341

sylfabre opened this issue Jun 6, 2018 · 2 comments
Labels

Comments

@sylfabre
Copy link
Contributor

sylfabre commented Jun 6, 2018

Q A
Bug report? yes
Feature request? no
Version/Branch 0.11.1

The following type definition works like a charm:

JohnConnection:
    type: relay-connection
    config:
        nodeType: String
        connectionFields:
            totalCount:
                type: "Int!"
                description: "Number of items in this collection"

If you remove the Connection suffix, it breaks:

John:
    type: relay-connection
    config:
        nodeType: String
        connectionFields:
            totalCount:
                type: "Int!"
                description: "Number of items in this collection"

with the following message:

Unrecognized option "_relay_connection_config" under "overblog_graphql_types.John"

@renatomefi
Copy link
Member

It's part of the code: https://github.com/overblog/GraphQLBundle/blob/master/Relay/Connection/ConnectionDefinition.php#L22

Now the question is: Is it intended? Or following the spec?

@mcg-web mcg-web added the bug label Jun 12, 2018
TomasLudvik added a commit to shopsys/shopsys that referenced this issue Dec 1, 2020
- it cannot be used in decorator because of bug overblog/GraphQLBundle#341
TomasLudvik added a commit to shopsys/shopsys that referenced this issue Dec 1, 2020
- it cannot be used in decorator because of bug overblog/GraphQLBundle#341
TomasLudvik added a commit to shopsys/shopsys that referenced this issue Dec 1, 2020
- it cannot be used in decorator because of bug overblog/GraphQLBundle#341
TomasLudvik added a commit to shopsys/shopsys that referenced this issue Dec 3, 2020
- it cannot be used in decorator because of bug overblog/GraphQLBundle#341
TomasLudvik added a commit to shopsys/shopsys that referenced this issue Dec 3, 2020
ShopsysBot pushed a commit to shopsys/project-base that referenced this issue Dec 3, 2020
@vitek-rostislav
Copy link

Hi, is there any information about this issue, please? It causes us problems when defining a connection decorator - we would have to follow the naming *DecoratorConnection instead of *ConnectionDecorator to overcome the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants