Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make decorator-usage as type a compile time error, instead of runtime #350

Open
akomm opened this issue Jun 18, 2018 · 2 comments
Open

Make decorator-usage as type a compile time error, instead of runtime #350

akomm opened this issue Jun 18, 2018 · 2 comments

Comments

@akomm
Copy link
Member

akomm commented Jun 18, 2018

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Version/Branch dev-master

First of all: nice feature. I used "decorators" often and now they are an actual feature and I can prevent them from going into the schema! 👍

Is it actually possible to throw error at compile time, when I have:

SomeType:
  type: 'object'
  config:
    fields:
      someField: { type: 'SomeDecoratorType' }

While SomeDecoratorType is an object with config.decorator: true.

Currently an error is thrown when query is being executed.

@mcg-web
Copy link
Member

mcg-web commented Jun 27, 2018

Ok I get it, do you want to work on this?

@akomm
Copy link
Member Author

akomm commented Jul 2, 2018

I still have another thing I wanted to make, which you labeled 1.2, but to be honest with decorators and some other new features it almost got obsolete.

IN case of this one - please give me your thought on this - maybe the issue is resolved anyway, if you simply have a test that makes a full introspection query. This would trigger the error not at compile time, but test time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants