Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests and capabilities to test server that match the real server #338

Open
jcaamano opened this issue Sep 29, 2022 · 0 comments · Fixed by #375
Open

Add more tests and capabilities to test server that match the real server #338

jcaamano opened this issue Sep 29, 2022 · 0 comments · Fixed by #375

Comments

@jcaamano
Copy link
Collaborator

  • Test server allows standlone ACLs, doesn't scream if we delete an ACL that is referenced by a portgroup or switch, real server behaves differently (referenctial integrity)
  • Test server doesn't scream when we provide a transact with acl name > 63 chars (type validation)
  • Integer limits for certain fields aren't enforced (validation)

See #219 as well
@jcaamano jcaamano mentioned this issue Sep 29, 2022
Open
tssurya added a commit to tssurya/ovn-kubernetes that referenced this issue Mar 6, 2023
@tssurya
Add test to showcase syncEgressFirewall isn't truncating ACL names
b7225fe 
This commit adds a test to showcase that
since syncEgressFirewall isn't calling libovsdbops.BuildACL
directly, we are not truncating ACL names.

Note that we really need ovn-org/libovsdb#338
for our test server to start screaming for long names.

Signed-off-by: Surya Seetharaman <[email protected]>
@tssurya tssurya mentioned this issue Mar 6, 2023
Merged
tssurya added a commit to tssurya/ovn-kubernetes that referenced this issue Mar 6, 2023
@tssurya
Add test to showcase syncEgressFirewall isn't truncating ACL names
d996d0e 
This commit adds a test to showcase that
since syncEgressFirewall isn't calling libovsdbops.BuildACL
directly, we are not truncating ACL names.

Note that we really need ovn-org/libovsdb#338
for our test server to start screaming for long names.

Signed-off-by: Surya Seetharaman <[email protected]>
npinaeva pushed a commit to npinaeva/ovn-kubernetes-openshift that referenced this issue Mar 7, 2023
@tssurya @npinaeva
Add test to showcase syncEgressFirewall isn't truncating ACL names
e6a85ac 
This commit adds a test to showcase that
since syncEgressFirewall isn't calling libovsdbops.BuildACL
directly, we are not truncating ACL names.

Note that we really need ovn-org/libovsdb#338
for our test server to start screaming for long names.

Signed-off-by: Surya Seetharaman <[email protected]>
(cherry picked from commit d996d0e)
npinaeva pushed a commit to npinaeva/ovn-kubernetes-openshift that referenced this issue Mar 7, 2023
@tssurya @npinaeva
Add test to showcase syncEgressFirewall isn't truncating ACL names
a74aaf6 
This commit adds a test to showcase that
since syncEgressFirewall isn't calling libovsdbops.BuildACL
directly, we are not truncating ACL names.

Note that we really need ovn-org/libovsdb#338
for our test server to start screaming for long names.

Signed-off-by: Surya Seetharaman <[email protected]>
(cherry picked from commit d996d0e)
(cherry picked from commit e6a85ac)
@jcaamano jcaamano mentioned this issue Jan 9, 2024
Merged
@jcaamano jcaamano reopened this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement test server referential integrity jcaamano/libovsdb
1 participant
@jcaamano