udn, e2e: Add external client to nodeport and loadblanacer services tests #4702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
from
eaa9650
to
75b26c9
Compare
qinqon
changed the title
|
we need tests for
@martinkennelly maybe talk to @qinqon and see if he needs you to help with half of these...? |
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
3 times, most recently
from
ceaf04f
to
b73b9e7
Compare
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
5 times, most recently
from
9938c6e
to
6e3bc40
Compare
|
some control-plane CI is failing |
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
3 times, most recently
from
308e286
to
d6f508f
Compare
github-actions
bot
added
feature/egress-ip
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
from
d6f508f
to
bcbabb8
Compare
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
from
bcbabb8
to
a99cbef
Compare
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
3 times, most recently
from
b3153cb
to
5f12a4a
Compare
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
from
5f12a4a
to
9e69dd4
Compare
|
/assign @tssurya |
maiqueb
previously approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thank you.
Just left a question to @ricky-rav and a suggestion to @qinqon .
Comment on lines
-57
to
-58
| By("Removing the namespace so all resources get deleted") | ||
| err := cs.CoreV1().Namespaces().Delete(context.TODO(), f.Namespace.Name, metav1.DeleteOptions{}) | ||
| framework.ExpectNoError(err, "Failed to remove the namespace %s %v", f.Namespace.Name, err) |
There was a problem hiding this comment.
@ricky-rav is there a reason why weren't relying on the framework's automatic teardown to clean up the namespace ? Just making sure - I couldn't come up with one.
@qinqon maybe we want to preserve the By clause (when deleting the defaultNetNamespace).
|
@maiqueb @ricky-rav I understand that the main difference here is that this test suite is create an extra namespace to work with default pod network. We should just use framework's |
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
from
9e69dd4
to
d8bca82
Compare
Latest metallb repo support dualstack at dev-env let's pin to it. Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Signed-off-by: Enrique Llorente <[email protected]>
Add testing for: - External clients to LB, NodePort and ExternalIPs - Podify clients to LB and ExternalIPs Also skipping testing not working yet with local gw mode. Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
primary-udn-external-to-nodePort-e2e
branch
from
d8bca82
to
8d6a215
Compare
|
hmm all the lanes are red? @qinqon can you rebase on latest master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
Add e2e test to check connectivity from external client to primary UDN nodeport and loadbalancer services
NOTE: This PR pins metallb to a commit since we don't have a release yet, but this can be fix later on.
Tests:
Which issue(s) this PR fixes
Fixes #4699