Skip to content

Print ModSecurity version from nginx connector #316

Closed
@theseion

Description

@theseion

With the nginx connector (v3), the log output currently looks like this:

2024/04/04 16:11:33 [notice] 630#630: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/824/0)
2024/04/04 16:11:37 [notice] 1#1: ModSecurity-nginx v1.0.3 (rules loaded inline/local/remote: 0/824/0)
2024/04/04 16:11:37 [notice] 1#1: using the "epoll" event method
2024/04/04 16:11:37 [notice] 1#1: nginx/1.25.3
2024/04/04 16:11:37 [notice] 1#1: built by gcc 12.2.0 (Debian 12.2.0-14) 
2024/04/04 16:11:37 [notice] 1#1: OS: Linux 6.1.0-18-amd64

It would be helpful to also log the ModSecurity version, not only the connector version.

Activity

self-assigned this
on Apr 9, 2024
airween

airween commented on Apr 9, 2024

@airween
Member

Thanks, I think that's a really useful feature request.

What do you think, what would be the better solution: make a new, separated line, or would be fine to append to the first line (before the part (rules loaded...)?

theseion

theseion commented on Apr 9, 2024

@theseion
Author

I think it's fine to append it to the same line. The ModSec and connector versions belong together anyway.
Maybe prepend it though: ModSecurity v3.0.12, ModSecurity-nginx v1.0.3....

airween

airween commented on Apr 23, 2024

@airween
Member

Please take a review: #319.

theseion

theseion commented on Apr 24, 2024

@theseion
Author

Fixed by #319.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @airween@theseion

      Issue actions

        Print ModSecurity version from nginx connector · Issue #316 · owasp-modsecurity/ModSecurity-nginx