-
-
Notifications
You must be signed in to change notification settings - Fork 21
WDI post-cleanup #3939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Rated as priority 2 because it's fresh on our minds and we have momentum. It would be more effort in the future. |
Hi @Marigold thanks for summarizing the main conclusions in this issue. I'm waiting for others' feedback on this thread to write back to WDI. PS: I'll merge my PR later today, to avoid blocking ETL in production. |
WDI people sent us some additional suggestions:
On the last point, I created a separate issue to keep as a reference for the future. |
Here are some notes from the WB discussion about WDI and from our chat prior to it:
load_snapshot
again. The garden step can simply depend on meadow step, which has two tables. We do something similar with FAOSTAT (although there the metadata is a separate dataset, which I think is a worse option).wdi.sources.json
andupdate_metadata.ipynb
), but it's inconsistent and doesn't follow our best practices (which have changed since switching from sources to origins). We could also extract more information into the origins fields.citation_full
, with as much detail as they provide.docs/data
, so I suppose the appropriate place to describe the update procedure and contact persons could be the docstring of the snapshot .py file.The text was updated successfully, but these errors were encountered: