chore!: remove getters because all fields are public (#60)

In line with the KISS principle, it makes little sense to have getters
when all fields are public anyway, and no complex validation is
performed.

Author: nyurik

Cargo.toml

@@ -24,7 +24,6 @@ serde = ["dep:serde"]
 with-serde = ["serde"]
 
 [dependencies]
-derive-getters = "0.5"
 encoding_rs = { version = "0.8", optional = true }
 nom = { version = "8.0", features = ["alloc"] }
 serde = { version = "1.0", features = ["derive"], optional = true }

README.md

@@ -24,10 +24,10 @@ fn main() {
     let dbc = Dbc::try_from(data.as_str()).expect("Failed to parse dbc file");
 
     let mut scope = Scope::new();
-    for msg in dbc.messages() {
-        let msg_struct = scope.new_struct(msg.name());
-        for signal in msg.signals() {
-            msg_struct.field(signal.name().to_lowercase().as_str(), "f64");
+    for msg in dbc.messages {
+        let msg_struct = scope.new_struct(&msg.name);
+        for signal in msg.signals {
+            msg_struct.field(&signal.name.to_lowercase(), "f64");
         }
     }
 

src/ast/attr_default.rs

@@ -1,11 +1,9 @@
-use derive_getters::Getters;
-
 use crate::ast::AttributeValue;
 
 // FIXME: not used!
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct AttrDefault {
-    name: String,
-    value: AttributeValue,
+    pub name: String,
+    pub value: AttributeValue,
 }

src/ast/attribute_default.rs

@@ -1,8 +1,6 @@
-use derive_getters::Getters;
-
 use crate::ast::AttributeValue;
 
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct AttributeDefault {
     pub name: String,

src/ast/attribute_value_for_object.rs

@@ -1,8 +1,6 @@
-use derive_getters::Getters;
-
 use crate::ast::AttributeValuedForObjectType;
 
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct AttributeValueForObject {
     pub name: String,

src/ast/dbc.rs

@@ -1,5 +1,3 @@
-use derive_getters::Getters;
-
 use crate::ast::{
     AttributeDefault, AttributeDefinition, AttributeValueForObject, Baudrate, Comment,
     EnvironmentVariable, EnvironmentVariableData, Error, ExtendedMultiplex, Message, MessageId,
@@ -9,7 +7,7 @@ use crate::ast::{
 };
 use crate::parser;
 
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct Dbc {
     /// Version generated by DB editor

src/ast/environment_variable.rs

@@ -1,8 +1,6 @@
-use derive_getters::Getters;
-
 use crate::ast::{AccessNode, AccessType, EnvType};
 
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct EnvironmentVariable {
     pub name: String,

src/ast/environment_variable_data.rs

@@ -1,6 +1,4 @@
-use derive_getters::Getters;
-
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct EnvironmentVariableData {
     pub env_var_name: String,

src/ast/extended_multiplex.rs

@@ -1,9 +1,7 @@
-use derive_getters::Getters;
-
 use crate::ast::{ExtendedMultiplexMapping, MessageId};
 
 /// Mapping between multiplexors and multiplexed signals
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct ExtendedMultiplex {
     pub message_id: MessageId,

src/ast/extended_multiplex_mapping.rs

@@ -1,6 +1,4 @@
-use derive_getters::Getters;
-
-#[derive(Clone, Debug, PartialEq, Getters)]
+#[derive(Clone, Debug, PartialEq)]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
 pub struct ExtendedMultiplexMapping {
     pub min_value: u64,