Skip to content

nexus: Clarify disks and boot_disk in instance create #8089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
david-crespo opened this issue May 5, 2025 · 1 comment · Fixed by #8192
Closed

nexus: Clarify disks and boot_disk in instance create #8089

david-crespo opened this issue May 5, 2025 · 1 comment · Fixed by #8192
Assignees
@sudomateo

Comments

@david-crespo
Copy link
Contributor

david-crespo commented May 5, 2025 •
edited
Loading

Another sentence on the disks description would go a long way. It would even show up in LSP hover on generated clients. There is some discussion in the boot_disk comment about how non-boot disks can still boot, but I think we can make it easier to understand.

https://docs.oxide.computer/api/instance_create

Image
@sudomateo sudomateo self-assigned this May 7, 2025
sudomateo added a commit that referenced this issue May 21, 2025
@sudomateo
nexus: update InstanceCreate documentation
8c905f2 
Updated the documentation for the `InstanceCreate` fields `disks` and
`boot_disk` to better clarify what they are and the implications of
configuring them.

Closes #8089.
@sudomateo sudomateo mentioned this issue May 21, 2025
Merged
@sudomateo
Copy link
Contributor

Submitted #8192 to update the documentation here.

sudomateo added a commit that referenced this issue May 22, 2025
@sudomateo
nexus: update InstanceCreate documentation
0746bf6 
Updated the documentation for the `InstanceCreate` fields `disks` and
`boot_disk` to better clarify what they are and the implications of
configuring them.

Closes #8089.
sudomateo added a commit that referenced this issue May 22, 2025
@sudomateo
nexus: update InstanceCreate documentation
c38a589 
Updated the documentation for the `InstanceCreate` fields `disks` and
`boot_disk` to better clarify what they are and the implications of
configuring them.

Closes #8089.
sudomateo added a commit that referenced this issue May 22, 2025
@sudomateo
nexus: update InstanceCreate documentation
0a87141 
Updated the documentation for the `InstanceCreate` fields `disks` and
`boot_disk` to better clarify what they are and the implications of
configuring them.

Closes #8089.
sudomateo added a commit that referenced this issue May 22, 2025
@sudomateo
nexus: update InstanceCreate documentation
3651697 
Updated the documentation for the `InstanceCreate` fields `disks` and
`boot_disk` to better clarify what they are and the implications of
configuring them.

Closes #8089.
sudomateo added a commit that referenced this issue May 23, 2025
@sudomateo
nexus: update InstanceCreate documentation
9f949c9 
Updated the documentation for the `InstanceCreate` fields `disks` and
`boot_disk` to better clarify what they are and the implications of
configuring them.

Closes #8089.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sudomateo sudomateo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nexus: update InstanceCreate documentation oxidecomputer/omicron
2 participants
@david-crespo @sudomateo