Update CHANGELOG.md and README.md

(cherry picked from commit acb4fc4d1f2fb61f299fd109027deb3dc8deb0e2)

Author: Georgi Neykov

CHANGELOG.md

@@ -1,31 +1,30 @@
 Changelog
 ==========
 
+Version 2.5.1 (17.02.2021)
+--------------------------
+
+## Composer
+
+- Fix a case in `DataApiResponseAdapter` where an API call with a non-success result code being adapted to a `DataApiResponse` will result in the underlying `Response` and `Connection` not being closed (and potentially reused).
+
 Version 2.5.0 (28.07.2020)
 --------------------------
 
 ## Client
 
-- Deprecate `ResponseBody.writeTo()`, `ResponseBody.valuesBytes()`,
- `ResponseBody.valuesByteArray()`.
+- Deprecate `ResponseBody.writeTo()`, `ResponseBody.valuesBytes()`, `ResponseBody.valuesByteArray()`.
 
-     The one-shot stream of data being held by a `ResponseBody`
-     needs to be decoded by a `ProtocolReader` before use. `ResponseBody.reader()`
-     returns such an instance which is already configured
-     and ready for reading making these methods redundant.
-     Also the aforementioned methods bring some behavior ambiguity in cases where
-     the stream may be partially consumed through the exposed `ProtocolReader`.
+     The one-shot stream of data being held by a `ResponseBody` needs to be decoded by a `ProtocolReader` before use. `ResponseBody.reader()` returns such an instance which is already configured and ready for reading making these methods redundant.
+     Also the aforementioned methods bring some behavior ambiguity in cases where the stream may be partially consumed through the exposed `ProtocolReader`.
 
-     **The methods will now throw an `IllegalStateException` if
-     called when the response has been partially read via a `ProtocolReader`.**
+     **The methods will now throw an `IllegalStateException` if called when the response has been partially read via a `ProtocolReader`.**
 
      **The methods will be removed in the next major release of the library.**
 
-- Fix potential connection leaks in `Call.enqueue()`
-and `Call.enqueueAndWait()` implementations.
-- Review connection closing/recycling in the `MultiCall` implementation
-- Add more assertions regarding connection recycling/closure in `Call`,
-`MultiCall` unit tests.
+- Fix potential connection leaks in `Call.enqueue()` and `Call.enqueueAndWait()` implementations.
+- Review connection closing/recycling in the `MultiCall` implementation.
+- Add more assertions regarding connection recycling/closure in `Call` and `MultiCall` unit tests.
 
 Version 2.4.1 (20.03.2020)
 --------------------------
@@ -154,13 +153,13 @@ Version 2.0.0 (05.01.2018)
 * Internal optimizations in `BytesWriter` to minimize allocations
 * More unit tests for `BytesWriter`
 * ProtocolResponseReader can now directly read the data after data-enriched responses.
-* Added the `SCOPE_DATA` scope in `ProtocolResponseReader` will be entered after all the values of a data-enriched       response are read and the `ProtocolResponseReader` is at the begging of the attached data bytes.
+* Added the `SCOPE_DATA` scope in `ProtocolResponseReader` will be entered after all the values of a data-enriched response are read and the `ProtocolResponseReader` is at the begging of the attached data bytes.
 * Add delegating implementations for `ProtocolReader`, `ProtocolResponseReader`, `ProtocolRequestWriter`and `ProtocolWriter`.
 
 #### Client
 
 * Add the `ApiChannel` low-level interface for writing and reading binary-encoded data to an API connection.
-	- This addition exposes the lowest possible level of detail when writing/reading messages from the API by still   	abstracting away the details of connection establishment, TLS handshaking and so on.
+	- This addition exposes the lowest possible level of detail when writing/reading messages from the API by still abstracting away the details of connection establishment, TLS handshaking and so on.
 	- The interface allows for pipelining of requests and reading/writing on separate threads.
 	- Instances of the interface can be opened via `PCloudApiClient.newChannel()`.
 

README.md

@@ -59,13 +59,13 @@ api.copy(...)
 <dependency>
   <groupId>com.pcloud.pcloud-networking-java</groupId>
   <artifactId>composer</artifactId>
-  <version>2.5.0</version>
+  <version>2.5.1</version>
   <type>pom</type>
 </dependency>
 ```
 
 ```groovy
-compile 'com.pcloud.pcloud-networking-java:composer:2.5.0'
+compile 'com.pcloud.pcloud-networking-java:composer:2.5.1'
 ```
 
 ### Client
@@ -87,13 +87,13 @@ The `binapi-client` module contains a network client for composing and executing
 <dependency>
   <groupId>com.pcloud.pcloud-networking-java</groupId>
   <artifactId>binapi-client</artifactId>
-  <version>2.5.0</version>
+  <version>2.5.1</version>
   <type>pom</type>
 </dependency>
 ```
 
 ```groovy
-compile 'com.pcloud.pcloud-networking-java:binapi-client:2.5.0'
+compile 'com.pcloud.pcloud-networking-java:binapi-client:2.5.1'
 ```
 
 --------------------------------------------------------------------------------
@@ -115,13 +115,13 @@ The `serialization` module contains a library for serializing Java objects to bi
 <dependency>
   <groupId>com.pcloud.pcloud-networking-java</groupId>
   <artifactId>serialization</artifactId>
-  <version>2.5.0</version>
+  <version>2.5.1</version>
   <type>pom</type>
 </dependency>
 ```
 
 ```groovy
-compile 'com.pcloud.pcloud-networking-java:serialization:2.5.0'
+compile 'com.pcloud.pcloud-networking-java:serialization:2.5.1'
 ```
 --------------------------------------------------------------------------------
 ### Protocol
@@ -142,13 +142,13 @@ The `protocol` module contains the core logic for writing/reading data in the fo
 <dependency>
   <groupId>com.pcloud.pcloud-networking-java</groupId>
   <artifactId>protocol</artifactId>
-  <version>2.5.0</version>
+  <version>2.5.1</version>
   <type>pom</type>
 </dependency>
 ```
 
 ```groovy
-compile 'com.pcloud.pcloud-networking-java:protocol:2.5.0'
+compile 'com.pcloud.pcloud-networking-java:protocol:2.5.1'
 ```
 
 ## License

publishing.gradle

@@ -17,8 +17,8 @@
 ext {
     isCi = System.getenv().containsKey('CI')
 
-    versionName = "2.5.0"
-    versionCode = 23
+    versionName = "2.5.1"
+    versionCode = 24
     libraryName = "pcloud-networking-java"
     groupId = "com.pcloud.pcloud-networking-java"
     description = "A Network Stack for pCloud's API written in Java"