Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tricky downloading plottable.min.js #3364

Closed
src73 opened this issue Jun 9, 2017 · 3 comments
Closed

Tricky downloading plottable.min.js #3364

src73 opened this issue Jun 9, 2017 · 3 comments

Comments

@src73
Copy link

src73 commented Jun 9, 2017

I just tried upgrading to the latest version (3.1.1) and encountered two issues:

  1. clicking the "download (latest)" button on plottablejs.org downloads the latest off of the Master branch, which hasn't been updated since 2015.
  2. the commit tagged 3.1.1 doesn't include a plottable.min.js file (or even plottable.js). This breaks unpkg, and makes it very difficult for those without NPM or Yarn to use the latest version of the library, even if just download the repo.

Do let me know if I'm missing something..

@hellochar
Copy link
Contributor

Hey @src73 , thanks for the report. 1 is filed as #3342 , apologies for that - we'll try to get around to it in the upcoming weeks.

I'm able to find the standalone plottable.js in 3.1.1 at https://unpkg.com/[email protected]/plottable.js, but I'd recommend pulling in Plottable through individual js modules npm/yarn - you'll notice package.json's main points to build/src/index.js. It's also for that reason we've recently removed the standalone .min.js file - we expect consumers to use Plottable with a module bundler like webpack or rollup, which has full bundle minification features. Does that work with how you are consuming the library?

@MartinKolarik
Copy link

@src73 if you want to use the file directly from a CDN, you can use jsDelivr, which supports on-the-fly minification: https://cdn.jsdelivr.net/npm/[email protected]/plottable.min.js

@hellochar
Copy link
Contributor

Closing - use jsDelivr (nice tip @MartinKolarik !) or a module bundler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants