Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum call stack size exceeded #3444

Closed
bnbarak opened this issue Feb 22, 2018 · 2 comments
Closed

Maximum call stack size exceeded #3444

bnbarak opened this issue Feb 22, 2018 · 2 comments

Comments

@bnbarak
Copy link

bnbarak commented Feb 22, 2018

Bug report

What

With Plottable version 3.7.0 and dataset size bigger than ~200,000, Plottable.js throws error when calling methods entityNearest or entityNearestByXThenY on a line chart.

Error

    at EntityStore.addAll (VM94 plottable.js:17524)
    at Line.Plot._getEntityStore (VM94 plottable.js:727)
    at Line.Plot.entityNearest (VM94 plottable.js:783)
    at window.onload ((index):85)

Also see image:
screen shot 2018-02-21 at 7 14 07 pm

Example

Version 2.0 example (working):
https://jsfiddle.net/mbzkx4eq/45/

Version: 3.7.0 (not working):
https://jsfiddle.net/mbzkx4eq/49/

Other

Running on OSX 0.11.6 and Chrome 64.0.3282.167 (Official Build) (64-bit)

@gidim
Copy link

gidim commented Feb 22, 2018

+1

@themadcreator
Copy link
Contributor

I tried out the example using 3.8.1 and it appears to be fixed.

Also, in the example you're using x coordinates that are dates, but with a categorical scale. Try using a Plottable.Scales.Time instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants