GH730 PR feedback

Author: loicdiridollou

pandas-stubs/core/frame.pyi

@@ -2314,7 +2314,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
         index: _bool = ...,
         na_rep: _str = ...,
         formatters: FormattersType | None = ...,
-        float_format: FloatFormatType | Callable[[float], str] | None = ...,
+        float_format: FloatFormatType | None = ...,
         sparsify: _bool | None = ...,
         index_names: _bool = ...,
         justify: _str | None = ...,
@@ -2337,7 +2337,7 @@ class DataFrame(NDFrame, OpsMixin, _GetItemHack):
         index: _bool = ...,
         na_rep: _str = ...,
         formatters: FormattersType | None = ...,
-        float_format: FloatFormatType | Callable[[float], str] | None = ...,
+        float_format: FloatFormatType | None = ...,
         sparsify: _bool | None = ...,
         index_names: _bool = ...,
         justify: _str | None = ...,

pandas-stubs/core/series.pyi

@@ -531,7 +531,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
         self,
         buf: FilePath | WriteBuffer[str],
         na_rep: _str = ...,
-        float_format: FloatFormatType | Callable[[float], str] = ...,
+        float_format: FloatFormatType = ...,
         header: _bool = ...,
         index: _bool = ...,
         length: _bool = ...,
@@ -545,7 +545,7 @@ class Series(IndexOpsMixin[S1], NDFrame):
         self,
         buf: None = ...,
         na_rep: _str = ...,
-        float_format: FloatFormatType | Callable[[float], str] = ...,
+        float_format: FloatFormatType = ...,
         header: _bool = ...,
         index: _bool = ...,
         length: _bool = ...,

tests/test_frame.py

@@ -1709,7 +1709,6 @@ def test_dataframe_to_string_float_fmt() -> None:
     def _formatter(x) -> str:
         return f"{x:.2f}"
 
-    check(assert_type(df.to_string(), str), str)
     check(assert_type(df.to_string(float_format=_formatter), str), str)
     check(
         assert_type(

tests/test_series.py

@@ -2944,7 +2944,6 @@ def test_series_to_string_float_fmt() -> None:
     def _formatter(x) -> str:
         return f"{x:.2f}"
 
-    check(assert_type(sr.to_string(), str), str)
     check(assert_type(sr.to_string(float_format=_formatter), str), str)
     check(
         assert_type(
@@ -2954,7 +2953,6 @@ def _formatter(x) -> str:
         str,
     )
     check(assert_type(sr.to_string(float_format="%.2f"), str), str)
-    check(assert_type(sr.to_string(float_format="%.2f"), str), str)
 
 
 def test_types_mask() -> None: