Skip to content

How we handle @final decorator in the stubs #1269

Open
@loicdiridollou

Description

@loicdiridollou

Opening this issue more as a discussion, I was doing some cleanup with the stubtest task and I have noticed that some of the methods in pandas annotated with @final are not always annotated as such in the stubs.
This generates around 500 warnings with the stubtest tasks. I know we have discussed it some times in PRs but wanted to open this issue to clarify how we should stand on it.
The main points are:

  • Should we also annotate the stubs with @final (it is partially done right now)?
  • What is the impact of having it? (or not having it)
  • Does it make a difference to have it or not?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions