move private imports from testing into tests/__init__.py #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Dr-Irv ! Just had a quick look: the changes look great! I will review/approve it later today. I assume we are still allowed to import from _typing inside the stubs? |
Yes. The issue that came up with pyright (and they removed the feature in 1.1.400 at my request - but want to put it back), is that if you installed So this PR is "centralizing" all of the imports from the private module, except for ones that I am proposing to put somewhere else. |
twoertwein
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for an eventual change in
pyrightthat would ban private imports, I have moved the private imports for the tests intotests/__init__.py.Also will be working to make some of the current private imports public as reflected in the discussion here:
pandas-dev/pandas#55231 (comment)