BUG: Improve ImportError message to suggest importing dependencies directly for full error details #61084
Conversation
|
Hi @rhshadrach , I have implemented your suggestion from the #61030. Could you please verify if this implementation meets your expectations? Thank you! Below are example outputs before and after this change:
|
There was a problem hiding this comment.
@mroeschke - what do you think about adding tzdata to the _hard_dependencies on L6 here.
pandas/__init__.py
Outdated
| "Unable to import required dependencies:\n" + "\n".join(_missing_dependencies) | ||
| "Unable to import required dependencies:\n" | ||
| + "\n".join(_missing_dependencies) | ||
| + "\n\nTo see the full error message, " |
There was a problem hiding this comment.
nit: You can remove the + on each line; Python will perform string concatenation automatically.
Also, I think we should remove one of the \n here:
ImportError: Unable to import required dependencies:
dateutil: No module named 'dateutil'
To see the full error message, try importing the missing dependencies directly.
vs
ImportError: Unable to import required dependencies:
dateutil: No module named 'dateutil'
To see the full error message, try importing the missing dependencies directly.
By removing the blank line, it is more apparent to me that it's all part of the same error message.
There was a problem hiding this comment.
Hmm what if we just change this to
for _dependency in _hard_dependencies:
try:
__import__(_dependency)
except ImportError as _e: # pragma: no cover
raise ImportError(f"Unable to import required dependency {_dependency} ...") from _eI know we won't be able to collect all the missing dependencies all at once but at least we'll maintain the traceback of the failed import
There was a problem hiding this comment.
@mroeschke - I'm good with your suggested approach, especially given how few hard dependencies pandas has.
rhshadrach
added
Build
Yeah we should probably add that too. |
@mroeschke For |
Please create a separate issue for this |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.