Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make trace_filter block range configurable #14930

Open
Rjected opened this issue Mar 10, 2025 · 1 comment · May be fixed by #14939
Open

Make trace_filter block range configurable #14930

Rjected opened this issue Mar 10, 2025 · 1 comment · May be fixed by #14939
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request

Comments

@Rjected
Copy link
Member

Rjected commented Mar 10, 2025

Right now we have a fixed max block range for trace_filter:

reth/crates/rpc/rpc/src/trace.rs

Line 260 in e49dfc0

if distance > 100 {

We should make this configurable, ideally via a cli argument, maybe we create one called --rpc.max-trace-filter-blocks?
@Rjected Rjected added A-rpc Related to the RPC implementation C-enhancement New feature or request labels Mar 10, 2025
@nadtech-hub
Copy link
Contributor

✋

@stevencartavia stevencartavia linked a pull request Mar 10, 2025 that will close this issue
Open
@Rjected Rjected mentioned this issue Mar 10, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make trace_filter block range configurable stevencartavia/reth
2 participants
@Rjected @nadtech-hub