Skip to content

Introduce Receipt69 variant #15510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattsse opened this issue Apr 3, 2025 · 3 comments · Fixed by #15827
Closed

Introduce Receipt69 variant #15510

mattsse opened this issue Apr 3, 2025 · 3 comments · Fixed by #15827
Assignees
@stevencartavia
Labels
A-networking Related to networking in general C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes

Comments

@mattsse
Copy link
Collaborator

mattsse commented Apr 3, 2025

Describe the feature

blocked by #15509 which removes te bloom from the p2p message.

we can introduce a new Receipts69 variant next to:

reth/crates/net/eth-wire-types/src/message.rs

Lines 226 to 231 in 48e0ec6

/// Represents a Receipts request-response pair.
#[cfg_attr(
feature = "serde",
serde(bound = "N::Receipt: serde::Serialize + serde::de::DeserializeOwned")
)]
Receipts(RequestPair<Receipts<N::Receipt>>),

This new variant is the same as

reth/crates/net/eth-wire-types/src/receipts.rs

Lines 26 to 29 in 48e0ec6

pub struct Receipts<T = Receipt>(
/// Each receipt hash should correspond to a block hash in the request.
pub Vec<Vec<ReceiptWithBloom<T>>>,
);

but with just Vec<Vec<T>>

we can reuse the same type if we lift the ReceiptWithBloom to the generic so that the legacy message will get Receipts< ReceiptWithBloom <T >> instead of Receipts<T> and the new Receipts69 will be Receipts<T>

cc @stevencartavia

Additional context

No response
@mattsse mattsse added A-networking Related to networking in general C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Apr 3, 2025
@shane-moore
Copy link
Contributor

hi, can I take a look?

@stevencartavia
Copy link
Contributor

🙋🏽‍♂️

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Apr 3, 2025
@mattsse
Copy link
Collaborator Author

mattsse commented Apr 3, 2025

@shane-moore I'm assigning @stevencartavia because this must be done as a followup to #15509

@stevencartavia stevencartavia mentioned this issue Apr 20, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevencartavia stevencartavia

Labels
A-networking Related to networking in general C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce Receipt69 variant stevencartavia/reth
3 participants
@mattsse @shane-moore @stevencartavia