From 4cdf55991e5f8a658f88d07f3b32ee1e1790e361 Mon Sep 17 00:00:00 2001 From: conomist Date: Fri, 28 Nov 2025 19:48:41 +0100 Subject: [PATCH 1/2] Update trace.rs --- crates/node/core/src/args/trace.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/crates/node/core/src/args/trace.rs b/crates/node/core/src/args/trace.rs index b94b83f4338..6b5ca4ade85 100644 --- a/crates/node/core/src/args/trace.rs +++ b/crates/node/core/src/args/trace.rs @@ -4,6 +4,8 @@ use clap::Parser; use eyre::WrapErr; use reth_tracing::{tracing_subscriber::EnvFilter, Layers}; use reth_tracing_otlp::OtlpProtocol; +#[cfg(feature = "otlp")] +use reth_tracing_otlp::OtlpConfig; use url::Url; /// CLI arguments for configuring `Opentelemetry` trace and span export. @@ -120,10 +122,10 @@ impl TraceArgs { /// Note: even though this function is async, it does not actually perform any async operations. /// It's needed only to be able to initialize the gRPC transport of OTLP tracing that needs to /// be called inside a tokio runtime context. - pub async fn init_otlp_tracing( - &mut self, - _layers: &mut Layers, - ) -> eyre::Result { + pub async fn init_otlp_tracing(&mut self, layers: &mut Layers) -> eyre::Result { + #[cfg(not(feature = "otlp"))] + let _ = layers; + if let Some(endpoint) = self.otlp.as_mut() { self.protocol.validate_endpoint(endpoint)?; From 54a9c0262f582768c04bd1936f4ffd5ef1532fdf Mon Sep 17 00:00:00 2001 From: conomist Date: Sat, 29 Nov 2025 12:02:58 +0100 Subject: [PATCH 2/2] Update trace.rs --- crates/node/core/src/args/trace.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/crates/node/core/src/args/trace.rs b/crates/node/core/src/args/trace.rs index 6b5ca4ade85..9bf404ab0a7 100644 --- a/crates/node/core/src/args/trace.rs +++ b/crates/node/core/src/args/trace.rs @@ -4,8 +4,6 @@ use clap::Parser; use eyre::WrapErr; use reth_tracing::{tracing_subscriber::EnvFilter, Layers}; use reth_tracing_otlp::OtlpProtocol; -#[cfg(feature = "otlp")] -use reth_tracing_otlp::OtlpConfig; use url::Url; /// CLI arguments for configuring `Opentelemetry` trace and span export.