Skip to content

Add ESLint to CI and Commit Hooks #1783

@dblythy

Description

@dblythy
Member

New Feature / Enhancement Checklist

  • I am not disclosing a vulnerability.
    I am not just asking a question.
    I have searched through existing issues.

Current Limitation

Currently, there is no ESLint enforcement on this repo. Nor is there an option to run npm run lint-fix like the other repo's have.

Feature / Enhancement Description

Having lint as part of our CI here would help detect bugs and poorly written code.

Example Use Case

Alternatives / Workarounds

Manually run lint

3rd Party References

Activity

parse-github-assistant

parse-github-assistant commented on Sep 5, 2021

@parse-github-assistant

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!
added
type:ciCI related issue
and removed on Sep 30, 2021
mtrezza

mtrezza commented on Oct 9, 2021

@mtrezza
Member

I personally am not particularly fond of commit hooks. I think we have discussed that in the past - a prettified code block may not always be the most practical style during code development. I would prefer a CI step over commit hooks. Unless having both brings any benefits?

dblythy

dblythy commented on Oct 9, 2021

@dblythy
MemberAuthor

I think commit hooks are good to make sure that PRs fit the lint standards that we apply, regardless of the additional styles of prettier. Hooks can always be skipped with --no-verify

mtrezza

mtrezza commented on Oct 9, 2021

@mtrezza
Member

As I understand it,
"ensuring" would be the purpose of the CI step
"adapting" would be the purpose of the commit hook

I don't believe it's developer friendly to force-prettify code they are still working on when making a commit. Just thinking about breakpoints that are set to specific lines, when suddenly the lines change because of a prettify. When working on a code block and the structure suddenly changes, that could also be somewhat disruptive as the developer would have to reorient visually. A developer would have to move to use git shell commands to use --no-verify because a git UI (like GitHub Desktop) rarely supports this flag.

When would these hooks be invoked?

added
bounty:$10Bounty applies for fixing this issue (Parse Bounty Program)
on Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bounty:$10Bounty applies for fixing this issue (Parse Bounty Program)type:ciCI related issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @dblythy@mtrezza

        Issue actions

          Add ESLint to CI and Commit Hooks · Issue #1783 · parse-community/parse-dashboard