[Models] Enable nullable (2 of 2) (#585)

Author: iamcarbon

Src/Fido2.Models/AssertionOptions.cs

@@ -11,6 +11,8 @@ namespace Fido2NetLib;
 /// </summary>
 public class AssertionOptions
 {
+#nullable disable
+
     /// <summary>
     /// This member represents a challenge that the selected authenticator signs, along with other data, when producing an authentication assertion.
     /// See the §13.1 Cryptographic Challenges security consideration.

Src/Fido2.Models/AuthenticatorAssertionRawResponse.cs

@@ -38,6 +38,8 @@ public AuthenticationExtensionsClientOutputs Extensions
     [JsonPropertyName("clientExtensionResults"), Required]
     public AuthenticationExtensionsClientOutputs ClientExtensionResults { get; set; }
 
+#nullable enable
+
     public sealed class AssertionResponse
     {
         [JsonConverter(typeof(Base64UrlConverter))]
@@ -52,8 +54,6 @@ public sealed class AssertionResponse
         [JsonPropertyName("clientDataJSON")]
         public required byte[] ClientDataJson { get; init; }
 
-#nullable enable
-
         [JsonPropertyName("userHandle")]
         [JsonConverter(typeof(Base64UrlConverter))]
         public byte[]? UserHandle { get; init; }

Src/Fido2.Models/AuthenticatorAttestationRawResponse.cs

@@ -1,4 +1,6 @@
-using System.ComponentModel.DataAnnotations;
+#nullable disable
+
+using System.ComponentModel.DataAnnotations;
 using System.Text.Json.Serialization;
 
 using Fido2NetLib.Objects;

Src/Fido2.Models/Converters/Base64UrlConverter.cs

@@ -1,6 +1,4 @@
-#nullable enable
-
-using System.Buffers;
+using System.Buffers;
 using System.Buffers.Text;
 using System.Text.Json;
 using System.Text.Json.Serialization;

Src/Fido2.Models/Converters/EnumNameMapper.cs

@@ -47,9 +47,9 @@ private static FrozenDictionary<TEnum, string> GetIdToNameMap()
         {
             var description = field.GetCustomAttribute<EnumMemberAttribute>(false);
 
-            var value = (TEnum)field.GetValue(null);
+            var value = (TEnum)field.GetValue(null)!;
 
-            items.Add(new(value, description is not null ? description.Value : value.ToString()));
+            items.Add(new(value, description is not null ? description.Value! : value.ToString()));
         }
 
         return items.ToFrozenDictionary();

Src/Fido2.Models/Converters/FidoEnumConverter.cs

@@ -12,7 +12,7 @@ public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerial
         switch (reader.TokenType)
         {
             case JsonTokenType.String:
-                string text = reader.GetString();
+                string text = reader.GetString()!;
                 if (EnumNameMapper<T>.TryGetValue(text, out T value))
                     return value;
                 else

Src/Fido2.Models/CredentialCreateOptions.cs

@@ -9,7 +9,6 @@ namespace Fido2NetLib;
 public sealed class CredentialCreateOptions
 {
     /// <summary>
-    ///
     /// This member contains data about the Relying Party responsible for the request.
     /// Its value’s name member is required.
     /// Its value’s id member specifies the relying party identifier with which the credential should be associated.If omitted, its value will be the CredentialsContainer object’s relevant settings object's origin's effective domain.
@@ -58,12 +57,16 @@ public sealed class CredentialCreateOptions
     [JsonPropertyName("attestationFormats")]
     public IReadOnlyList<AttestationStatementFormatIdentifier> AttestationFormats { get; set; } = [];
 
+#nullable disable
+
     /// <summary>
     /// This member is intended for use by Relying Parties that wish to select the appropriate authenticators to participate in the create() operation.
     /// </summary>
     [JsonPropertyName("authenticatorSelection")]
     public AuthenticatorSelection AuthenticatorSelection { get; set; }
 
+#nullable enable
+
     private IReadOnlyList<PublicKeyCredentialHint> _hints = Array.Empty<PublicKeyCredentialHint>();
 
     /// <summary>
@@ -113,7 +116,7 @@ public IReadOnlyList<PublicKeyCredentialHint> Hints
     /// </summary>
     [JsonPropertyName("extensions")]
     [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
-    public AuthenticationExtensionsClientInputs Extensions { get; set; }
+    public AuthenticationExtensionsClientInputs? Extensions { get; set; }
 
     public static CredentialCreateOptions Create(
         Fido2Configuration config,
@@ -122,7 +125,7 @@ public static CredentialCreateOptions Create(
         AuthenticatorSelection authenticatorSelection,
         AttestationConveyancePreference attestationConveyancePreference,
         IReadOnlyList<PublicKeyCredentialDescriptor> excludeCredentials,
-        AuthenticationExtensionsClientInputs extensions,
+        AuthenticationExtensionsClientInputs? extensions,
         IReadOnlyList<PubKeyCredParam> pubKeyCredParams)
 
     {
@@ -147,12 +150,10 @@ public string ToJson()
 
     public static CredentialCreateOptions FromJson(string json)
     {
-        return JsonSerializer.Deserialize(json, FidoModelSerializerContext.Default.CredentialCreateOptions);
+        return JsonSerializer.Deserialize(json, FidoModelSerializerContext.Default.CredentialCreateOptions)!;
     }
 }
 
-#nullable enable
-
 /// <summary>
 /// Constructs a PubKeyCredParam instance
 /// </summary>

Src/Fido2.Models/Fido2.Models.csproj

@@ -5,6 +5,7 @@
     <RootNamespace>Fido2NetLib</RootNamespace>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <IsTrimmable>true</IsTrimmable>
+    <Nullable>enable</Nullable>
     <NoWarn>$(NoWarn);CS1591</NoWarn>
     <IsPackable>true</IsPackable>
   </PropertyGroup>

Src/Fido2.Models/Fido2Configuration.cs

@@ -1,4 +1,6 @@
-using System.Runtime.Serialization;
+#nullable disable
+
+using System.Runtime.Serialization;
 
 namespace Fido2NetLib;
 

Src/Fido2.Models/Metadata/BiometricStatusReport.cs

@@ -31,19 +31,19 @@ public class BiometricStatusReport
     /// <para>If no date is given, the status is assumed to be effective while present.</para>
     /// </summary>
     [JsonPropertyName("effectiveDate")]
-    public string EffectiveDate { get; set; }
+    public string? EffectiveDate { get; set; }
 
     /// <summary>
     /// Gets or sets the externally visible aspects of the Biometric Certification evaluation.
     /// </summary>
     [JsonPropertyName("certificationDescriptor")]
-    public string CertificationDescriptor { get; set; }
+    public string? CertificationDescriptor { get; set; }
 
     /// <summary>
     /// Gets or sets the unique identifier for the issued Biometric Certification.
     /// </summary>
     [JsonPropertyName("certificateNumber")]
-    public string CertificateNumber { get; set; }
+    public string? CertificateNumber { get; set; }
 
     /// <summary>
     /// Gets or sets the  version of the Biometric Certification Policy the implementation is Certified to.
@@ -52,7 +52,7 @@ public class BiometricStatusReport
     /// For example: "1.0.0".
     /// </remarks>
     [JsonPropertyName("certificationPolicyVersion")]
-    public string CertificationPolicyVersion { get; set; }
+    public string? CertificationPolicyVersion { get; set; }
 
     /// <summary>
     /// Gets or sets the version of the Biometric Requirements the implementation is certified to.
@@ -61,5 +61,5 @@ public class BiometricStatusReport
     /// For example: "1.0.0".
     /// </remarks>
     [JsonPropertyName("certificationRequirementsVersion")]
-    public string CertificationRequirementsVersion { get; set; }
+    public string? CertificationRequirementsVersion { get; set; }
 }