Added the -Wall flag.

Author: Patrick Thomson

YAMLKit.xcodeproj/project.pbxproj

@@ -397,12 +397,14 @@
 				GCC_OPTIMIZATION_LEVEL = 0;
 				GCC_WARN_ABOUT_MISSING_PROTOTYPES = NO;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
+				GCC_WARN_PEDANTIC = NO;
 				GCC_WARN_UNUSED_VARIABLE = YES;
 				HEADER_SEARCH_PATHS = /usr/local/include/;
 				LIBRARY_SEARCH_PATHS = /usr/local/lib/;
 				ONLY_ACTIVE_ARCH = YES;
 				PREBINDING = NO;
 				SDKROOT = macosx10.5;
+				WARNING_CFLAGS = "-Wall";
 			};
 			name = Debug;
 		};
@@ -414,11 +416,13 @@
 				GCC_ENABLE_OBJC_GC = supported;
 				GCC_WARN_ABOUT_MISSING_PROTOTYPES = NO;
 				GCC_WARN_ABOUT_RETURN_TYPE = YES;
+				GCC_WARN_PEDANTIC = NO;
 				GCC_WARN_UNUSED_VARIABLE = YES;
 				HEADER_SEARCH_PATHS = /usr/local/include/;
 				LIBRARY_SEARCH_PATHS = /usr/local/lib/;
 				PREBINDING = NO;
 				SDKROOT = macosx10.5;
+				WARNING_CFLAGS = "-Wall";
 			};
 			name = Release;
 		};

src/YKEmitter.m

@@ -14,7 +14,7 @@ @implementation YKEmitter
 
 - (id)init
 {
-    if(self = [super init]) {
+    if((self = [super init])) {
         memset(&emitter, 0, sizeof(emitter));
         yaml_emitter_initialize(&emitter);
 
@@ -34,6 +34,8 @@ - (void)emitItem:(id)item
     // Create and initialize a document to hold this.
     yaml_document_t document;
     memset(&document, 0, sizeof(document));
+    // The double usage of !usesExplicitDelimiters is to indicate that both the start and the end of the 
+    // document should be delimited, if at all.
     yaml_document_initialize(&document, NULL, NULL, NULL, !usesExplicitDelimiters, !usesExplicitDelimiters);
 
     [self _writeItem:item toDocument:&document];

src/YKParser.m

@@ -65,7 +65,6 @@ - (NSArray *)parseWithError:(NSError **)e
         if(!yaml_parser_parse(&parser, &event)) {
 			if(e != NULL) {
 				*e = [self _constructErrorFromParser:&parser];
-				return nil;
 			}
             return nil;
 		}
@@ -166,6 +165,7 @@ - (NSError *)_constructErrorFromParser:(yaml_parser_t *)p
 			case YAML_UTF16BE_ENCODING:
 				enc = NSUTF16BigEndianStringEncoding;
 				break;
+			default: break;
 		}
 		[data setObject:[NSNumber numberWithInt:enc] forKey:NSStringEncodingErrorKey];