Merge remote-tracking branch 'remotes/Daniel-Cortez/error-094' into dev

Author: Y-Less

source/compiler/sc3.c

@@ -620,6 +620,10 @@ static void plnge2(void (*oper)(void),
     } /* if */
     /* ??? ^^^ should do same kind of error checking with functions */
 
+    /* If we're handling a division operation, make sure the divisor is not zero. */
+    if ((oper==os_div || oper==os_mod) && lval2->ident==iCONSTEXPR && lval2->constval==0)
+      error(94); /* division by zero */
+
     /* check whether an "operator" function is defined for the tag names
      * (a constant expression cannot be optimized in that case)
      */
@@ -648,10 +652,8 @@ static cell flooreddiv(cell a,cell b,int return_remainder)
 {
   cell q,r;
 
-  if (b==0) {
-    error(29);
+  if (b==0)
     return 0;
-  } /* if */
   /* first implement truncated division in a portable way */
   #define IABS(a)       ((a)>=0 ? (a) : (-a))
   q=IABS(a)/IABS(b);

source/compiler/sc5.c

@@ -132,7 +132,8 @@ static char *errmsg[] = {
 /*090*/  "public functions may not return arrays (symbol \"%s\")\n",
 /*091*/  "ambiguous constant; tag override is required (symbol \"%s\")\n",
 /*092*/  "functions may not return arrays of unknown size (symbol \"%s\")\n",
-/*093*/  "\"__addressof\" operator is invalid in preprocessor expressions\n"
+/*093*/  "\"__addressof\" operator is invalid in preprocessor expressions\n",
+/*094*/  "division by zero\n"
 };
 
 static char *fatalmsg[] = {

source/compiler/tests/error_094.meta

@@ -0,0 +1,9 @@
+{
+  'test_type': 'output_check',
+  'errors': """
+error_094.pwn(6) : error 094: division by zero
+error_094.pwn(7) : error 094: division by zero
+error_094.pwn(13) : error 094: division by zero
+error_094.pwn(14) : error 094: division by zero
+"""
+}

source/compiler/tests/error_094.pwn

@@ -0,0 +1,20 @@
+#include <console>
+
+main()
+{
+	// Case 1: Both operands are compile-time constants
+	printf("%d", 1 / 0); // error 094
+	printf("%d", 1 % 0); // error 094
+	printf("%d", 1 / 1);
+	printf("%d", 1 % 1);
+
+	// Case 2: Only the divisor is a constant
+	new var = 0;
+	printf("%d", var / 0); // error 094
+	printf("%d", var % 0); // error 094
+	printf("%d", var / 1);
+	printf("%d", var % 1);
+
+	printf("%d", 1 / var); // Just to make sure the error works only
+	printf("%d", 1 % var); // if the divisor is a constant value
+}