Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

displayPreview property on collection doesn't work #11404

Open
jensjeflensje opened this issue Feb 26, 2025 · 1 comment · May be fixed by #11496
Open

displayPreview property on collection doesn't work #11404

jensjeflensje opened this issue Feb 26, 2025 · 1 comment · May be fixed by #11496
Assignees
@JessChowdhury

Comments

@jensjeflensje
Copy link

Describe the Bug

The displayPreview option in the UploadConfig on a collection doesn't seem to be having any effect.
This is a problem when using large files, as Payload has to download the whole thing (when using S3).

Link to the code that reproduces this issue

https://github.com/jensjeflensje/payload/tree/display-preview

Reproduction Steps

  • Clone my reproduction repository on the branch display-preview
    • (the only thing I did was set displayPreview to false in the Media collection)
  • Run the project (pnpm dev _community)
  • Go into the admin panel and upload an image or any other file. The preview still shows

Which area(s) are affected? (Select all that apply)

area: core

Environment Info

Payload: 3.24.0
Node.js: v20.18.0
Next.js: 15.1.5
@jensjeflensje jensjeflensje added status: needs-triage Possible bug which hasn't been reproduced yet validate-reproduction Auto-added tag on create to tell bot to check recreation URL, removed after check. labels Feb 26, 2025
@github-actions github-actions bot removed the validate-reproduction Auto-added tag on create to tell bot to check recreation URL, removed after check. label Feb 26, 2025
@JessChowdhury JessChowdhury self-assigned this Mar 3, 2025
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Mar 3, 2025
@JessChowdhury JessChowdhury linked a pull request Mar 3, 2025 that will close this issue
Open
@JessChowdhury
Copy link
Member

Hi @jensjeflensje - thanks for opening this!
You are right, the displayPreview option is not affecting all the previews correctly.
I have a fix in this PR, we will aim to get it reviewed and merged in ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessChowdhury JessChowdhury

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): upload.displayPreview should affect all previews in the admin panel payloadcms/payload
2 participants
@jensjeflensje @JessChowdhury