Adding ability to set additional ChromeOptions in the .NET bindings

This allows the ability to set user profile preferences and local state
preferences using the ChromeOptions class. The new
AddUserProfilePreference and AddLocalStatePreference methods correspond to
the "prefs" and "localState" capabilities documented in the chromedriver
documentation. Note that the values passed in to these methods must be
JSON-serializable, and no validation is done on these values at present.
We now also allow setting the "detach" capability, which allows the user
to specify that Chrome remain running after chromedriver.exe has quit.

This commit also removes legacy code for the obsolete chrome.binary and
chrome.switches capabilities, and changes the command line arguments to
chromedriver.exe to include two hyphens, instead of one (e.g., "--silent"
instead of "-silent").

Author: jimevans

dotnet/src/webdriver/Chrome/ChromeDriverService.cs

@@ -63,12 +63,12 @@ protected override string CommandLineArguments
                 StringBuilder argsBuilder = new StringBuilder(base.CommandLineArguments);
                 if (this.SuppressInitialDiagnosticInformation)
                 {
-                    argsBuilder.Append(" -silent");
+                    argsBuilder.Append(" --silent");
                 }
 
                 if (!string.IsNullOrEmpty(this.logPath))
                 {
-                    argsBuilder.Append(string.Format(CultureInfo.InvariantCulture, " -log-path={0}", this.logPath));
+                    argsBuilder.Append(string.Format(CultureInfo.InvariantCulture, " --log-path={0}", this.logPath));
                 }
 
                 return argsBuilder.ToString();

dotnet/src/webdriver/Chrome/ChromeOptions.cs

@@ -62,11 +62,14 @@ public class ChromeOptions
         /// </summary>
         public static readonly string Capability = "chromeOptions";
 
+        private bool leaveBrowserRunning;
         private string binaryLocation;
         private List<string> arguments = new List<string>();
         private List<string> extensionFiles = new List<string>();
         private List<string> encodedExtensions = new List<string>();
         private Dictionary<string, object> additionalCapabilities = new Dictionary<string, object>();
+        private Dictionary<string, object> userProfilePreferences;
+        private Dictionary<string, object> localStatePreferences;
         private Proxy proxy;
 
         /// <summary>
@@ -79,6 +82,17 @@ public string BinaryLocation
             set { this.binaryLocation = value; }
         }
 
+        /// <summary>
+        /// Gets or sets a value indicating whether Chrome should be left running after the
+        /// ChromeDriver instance is exited. Defaults to <see langword="false"/>.
+        /// </summary>
+        [JsonProperty("detach")]
+        public bool LeaveBrowserRunning
+        {
+            get { return leaveBrowserRunning; }
+            set { leaveBrowserRunning = value; }
+        }
+
         /// <summary>
         /// Gets or sets the proxy to use with this instance of Chrome.
         /// </summary>
@@ -118,6 +132,18 @@ public ReadOnlyCollection<string> Extensions
             }
         }
 
+        [JsonProperty("prefs", NullValueHandling = NullValueHandling.Ignore)]
+        private Dictionary<string, object> UserProfilePreferences
+        {
+            get { return userProfilePreferences; }
+        }
+
+        [JsonProperty("localState", NullValueHandling = NullValueHandling.Ignore)]
+        private Dictionary<string, object> LocalStatePreferences
+        {
+            get { return localStatePreferences; }
+        }
+
         /// <summary>
         /// Adds a single argument to the list of arguments to be appended to the Chrome.exe command line.
         /// </summary>
@@ -258,6 +284,38 @@ public void AddEncodedExtensions(IEnumerable<string> extensions)
             }
         }
 
+        /// <summary>
+        /// Adds a preference for the user-specific profile or "user data directory."
+        /// If the specified preference already exists, it will be overwritten.
+        /// </summary>
+        /// <param name="preferenceName">The name of the preference to set.</param>
+        /// <param name="preferenceValue">The value of the preference to set.</param>
+        public void AddUserProfilePreference(string preferenceName, object preferenceValue)
+        {
+            if (this.userProfilePreferences == null)
+            {
+                this.userProfilePreferences = new Dictionary<string, object>();
+            }
+
+            this.userProfilePreferences[preferenceName] = preferenceValue;
+        }
+
+        /// <summary>
+        /// Adds a preference for the local state file in the user's data directory for Chrome.
+        /// If the specified preference already exists, it will be overwritten.
+        /// </summary>
+        /// <param name="preferenceName">The name of the preference to set.</param>
+        /// <param name="preferenceValue">The value of the preference to set.</param>
+        public void AddLocalStatePreference(string preferenceName, object preferenceValue)
+        {
+            if (this.localStatePreferences == null)
+            {
+                this.localStatePreferences = new Dictionary<string, object>();
+            }
+
+            this.localStatePreferences[preferenceName] = preferenceValue;
+        }
+
         /// <summary>
         /// Provides a means to add additional capabilities not yet added as type safe options 
         /// for the Chrome driver.
@@ -297,16 +355,6 @@ public ICapabilities ToCapabilities()
             DesiredCapabilities capabilities = DesiredCapabilities.Chrome();
             capabilities.SetCapability(ChromeOptions.Capability, this);
 
-            // chromeOptions is only recognized by chromedriver 17.0.963.0 or newer.
-            // Provide backwards compatibility for capabilities supported by older
-            // versions of chromedriver.
-            // TODO: remove this once the deprecated capabilities are no longer supported.
-            capabilities.SetCapability("chrome.switches", this.arguments);
-            if (!string.IsNullOrEmpty(this.binaryLocation))
-            {
-                capabilities.SetCapability("chrome.binary", this.binaryLocation);
-            }
-
             if (this.proxy != null)
             {
                 capabilities.SetCapability(CapabilityType.Proxy, this.proxy);